Add type parameter to remaining Series.astype overloads. #949
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dr-Irv
requested changes
Jun 28, 2024
Dr-Irv
requested changes
Jun 28, 2024
pandas-stubs/core/series.pyi
Outdated
| @@ -1320,14 +1320,14 @@ class Series(IndexOpsMixin[S1], NDFrame): | |||
| dtype: CategoryDtypeArg, | |||
| copy: _bool = ..., | |||
| errors: IgnoreRaise = ..., | |||
| ) -> Series: ... | |||
| ) -> Series[CategoryDtypeArg]: ... | |||
There was a problem hiding this comment.
This needs to be CategoryDtype as it is value in S1
There was a problem hiding this comment.
Made the change
tests/test_series.py
Outdated
Comment on lines
2584
to
2585
| assert_type(s.astype(pd.CategoricalDtype()), "pd.Series[CategoryDtypeArg]") | ||
| assert_type(s.astype("category"), "pd.Series[CategoryDtypeArg]") |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
assert_type()to assert the type of any return valueCloses #948
Verified that some of the test statements here pass pyright strict with this change that do not do so without.
Tested using
objectinstead ofAnyas that is the runtime behaviour, but that did not work due to the parameter bounds.Other option (maybe better?) would be to explicitely return as series matching the specified parameter? But i think that does not work either because the bounds of the type parameter for series are more restrictive than the input arguments for
astype.