Skip to content

Conversation

klkvr
Copy link
Member

@klkvr klkvr commented Oct 1, 2024

Adds a BLSMultisig contract demonstrating a mutlisignature account implementation controlled by BLS keys along with example demonstrating it integration in Rust with alloy and blst lib.

It doesn't look like there's a clean way to sign arbitrary points through blst without unsafe blocks, so there is a decent amount of them

Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is great!

I'm not that familiar with the blst API, so would appreciate if @fgimenez could take a look

@klkvr klkvr force-pushed the klkvr/more-examples branch from 3482bc3 to f4e9932 Compare October 1, 2024 19:06
@klkvr
Copy link
Member Author

klkvr commented Oct 1, 2024

Added example in Python as well, does pretty much the same thing

Copy link
Member

@fgimenez fgimenez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Co-authored-by: Federico Gimenez <fgimenez@users.noreply.github.com>
Copy link
Member

@fgimenez fgimenez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe not for this PR but it would be very nice to be able to run these examples on CI to make sure they keep working, wdyt?

@klkvr
Copy link
Member Author

klkvr commented Oct 2, 2024

maybe not for this PR but it would be very nice to be able to run these examples on CI to make sure they keep working, wdyt?

yep definitely, let's do it in a follow-up

"../../../out/BLSMultisig.sol/BLSMultisig.json"
}

impl From<[u8; 96]> for BLS::G1Point {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes me think we should create an alloy-bls package which also includes a tx signer for the AlphaNet payloads for the BatchContract -- cc @jxom

@klkvr klkvr merged commit cc6edd5 into paradigmxyz:main Oct 4, 2024
1 check passed
@klkvr klkvr mentioned this pull request Oct 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants