Skip to content

SealedBlock encodable only encodes the body #18002

New issue
New issue
Closed as not planned
#18524
Closed as not planned
SealedBlock encodable only encodes the body#18002
#18524
Labels
C-bugAn unexpected or incorrect behaviorC-enhancementNew feature or requestS-staleThis issue/PR is stale and will close with no further activity
@mattsse

Description

@mattsse
mattsse
opened on Aug 22, 2025

Describe the feature

these aren't symmetrical:

reth/crates/primitives-traits/src/block/sealed.rs

Lines 309 to 320 in d8e8d67

impl<B: Block> Encodable for SealedBlock<B> {
fn encode(&self, out: &mut dyn BufMut) {
self.body.encode(out);
}
}
impl<B: Block> Decodable for SealedBlock<B> {
fn decode(buf: &mut &[u8]) -> alloy_rlp::Result<Self> {
let block = B::decode(buf)?;
Ok(Self::seal_slow(block))
}
}

we need to fix this so that we encode the header then encode the block

a quick fix for this is .clone().into_block().encode

but this is a bit expensive.
it's a bit tricky because we'd need something like this to make this more efficient

reth/crates/primitives-traits/src/block/mod.rs

Lines 143 to 144 in d8e8d67

/// Returns the rlp length of the block with the given header and body.
fn rlp_length(header: &Self::Header, body: &Self::Body) -> usize;

Additional context

No response

Metadata

Metadata

Assignees

No one assigned

    Labels

    C-bugAn unexpected or incorrect behaviorC-enhancementNew feature or requestS-staleThis issue/PR is stale and will close with no further activity

    Type

    No type

    Projects

    Reth Tracker

    Status

    Done

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions