-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Open
Labels
A-engineRelated to the engine implementationRelated to the engine implementationC-enhancementNew feature or requestNew feature or requestC-perfA change motivated by improving speed, memory usage or disk footprintA change motivated by improving speed, memory usage or disk footprint
Description
Describe the feature
we should do similar thing here as we do in sparse trie updates
reth/crates/engine/tree/src/tree/payload_processor/sparse_trie.rs
Lines 81 to 86 in e9598ba
| num_iterations += 1; | |
| let mut num_updates = 1; | |
| while let Ok(next) = self.updates.try_recv() { | |
| update.extend(next); | |
| num_updates += 1; | |
| } |
basically drain the channel, aggregate everything, and then batch
Additional context
In MultiProofTask::run, mirror the sparse trie pattern
reth/crates/engine/tree/src/tree/payload_processor/sparse_trie.rs
by draining additional PrefetchProofs / StateUpdate messages with try_recv and merging their targets before handing them to the manager. Current handling without draining:
reth/crates/engine/tree/src/tree/payload_processor/multiproof.rs
Metadata
Metadata
Assignees
Labels
A-engineRelated to the engine implementationRelated to the engine implementationC-enhancementNew feature or requestNew feature or requestC-perfA change motivated by improving speed, memory usage or disk footprintA change motivated by improving speed, memory usage or disk footprint
Type
Projects
Status
Backlog