Skip to content

feat(cli): enable tokio handle in CliRunner #18018

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 16 commits into
base: main
Choose a base branch
from
Open

feat(cli): enable tokio handle in CliRunner #18018

wants to merge 16 commits into from

Conversation

lean-apple
Copy link
Contributor

@lean-apple lean-apple commented Aug 23, 2025 •
edited
Loading

Closes #17965.

@github-project-automation github-project-automation bot moved this to Backlog in Reth Tracker Aug 23, 2025
@lean-apple lean-apple changed the title refactor(cli): enable tokio handle in clirunner refactor(cli): enable tokio handle in CliRunner Aug 23, 2025
@lean-apple lean-apple changed the title refactor(cli): enable tokio handle in CliRunner feat(cli): enable tokio handle in CliRunner Aug 23, 2025
@lean-apple lean-apple marked this pull request as ready for review August 23, 2025 17:23
@lean-apple lean-apple requested a review from mattsse as a code owner August 23, 2025 17:23
mattsse
mattsse requested changes Aug 27, 2025
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool, only a few style nits

crates/cli/runner/src/lib.rs Outdated
Comment on lines 18 to 25
/// A tokio runtime or handle.
#[derive(Debug)]
enum RuntimeOrHandle {
/// Owned runtime that can be used for blocking operations
Runtime(Runtime),
/// Handle to an existing runtime
Handle(Handle),
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we move this end of file so that the first type remains the pub one?

@github-project-automation github-project-automation bot moved this from Backlog to In Progress in Reth Tracker Aug 27, 2025
SuperFluffy
SuperFluffy reviewed Aug 27, 2025
View reviewed changes
SuperFluffy
SuperFluffy reviewed Aug 27, 2025
View reviewed changes
@lean-apple lean-apple requested a review from mattsse August 27, 2025 17:45
@github-actions github-actions bot added the S-stale This issue/PR is stale and will close with no further activity label Sep 18, 2025
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Sep 24, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #18018 will not alter performance

Comparing lean-apple:tokio-handle-cli-runner (de9d883) with main (d2070f4)

Summary

✅ 77 untouched

@github-actions github-actions bot removed the S-stale This issue/PR is stale and will close with no further activity label Sep 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mattsse mattsse Awaiting requested review from mattsse mattsse is a code owner

1 more reviewer

@SuperFluffy SuperFluffy SuperFluffy left review comments

Reviewers whose approvals may not affect merge requirements

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

Reth Tracker
Status: In Progress

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Support tokio handle in CliRunner

3 participants

@lean-apple @SuperFluffy @mattsse