fix: make SealedBlock::encode symmetrical and zero-copy #18524
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
radik878
requested review from
Rjected,
RomanHodulak,
mattsse and
klkvr
as code owners
mattsse
reviewed
Sep 18, 2025
Comment on lines
311
to
317
| // Compute payload length as the sum of the header and body payload lengths. | ||
| // This must exclude the outer list header bytes to be symmetrical with plain Block RLP. | ||
| let payload_length = | ||
| alloy_rlp::Encodable::length(self.header()) + alloy_rlp::Encodable::length(self.body()); | ||
| alloy_rlp::Header { list: true, payload_length }.encode(out); | ||
| self.header().encode(out); | ||
| self.body().encode(out); |
There was a problem hiding this comment.
this is slightly problematic because this now assumes that B always decodes like this, which may or may not be the case
There was a problem hiding this comment.
this is slightly problematic because this now assumes that
Balways decodes like this, which may or may not be the case
corrected
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix SealedBlock encodable only encodes the body #18002