Skip to content

feat: support block number in required-block-hashes parameter #18546

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

feat: support block number in required-block-hashes parameter #18546

wants to merge 3 commits into from

Conversation

leniram159
Copy link
Contributor

@leniram159 leniram159 commented Sep 18, 2025 •
edited
Loading

Implements support for block number in the --required-block-hashes parameter as requested in issue #18543.

  • Accept BlockNumHash instead of B256 for required block hashes
  • Add parser for block_number=hash format (e.g., 23115201=0x1234...)
  • Skip block checks when peer's latest block is below required block number
  • Maintain backward compatibility with hash-only format

@github-project-automation github-project-automation bot moved this to Backlog in Reth Tracker Sep 18, 2025
@leniram159 leniram159 requested a review from gakonst as a code owner September 18, 2025 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse Awaiting requested review from mattsse mattsse is a code owner

@Rjected Rjected Awaiting requested review from Rjected Rjected is a code owner

@klkvr klkvr Awaiting requested review from klkvr klkvr is a code owner

@gakonst gakonst Awaiting requested review from gakonst gakonst is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
Reth Tracker
Status: Backlog
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@leniram159