fix(engine): handle RemovingBlocks persistence action during reorganization #18567
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix the issue #18408
Thanks @acerone85 for the detailed issue report, I think I partly understood the issue.
During reorganization, when
find_disk_reorg()
detects the need to remove blocks and starts aRemoveBlocks
operation, incoming blocks were incorrectly classified asPersistingNotDescendant
.This disabled parallel state root computation, forcing sequential computation that tried to access headers already removed by the ongoing removal job, resulting in fatal errors.
The race condition sequence:
remove_blocks()
called → persistence state set toRemovingBlocks
persisting_kind_for()
seesRemovingBlocks
→ returnsPersistingNotDescendant