fix(cli): db diff correctly handles tail elements using two-cursor merge #18568
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The db diff implementation used zip over walkers, which stops at the end of the shorter iterator. As a result, any remaining keys present only in the longer table were never visited and thus not recorded as extra elements. This caused incomplete diff reports whenever table lengths differed.
This change replaces the zipped walk with a two-cursor merge over sorted keys:
Rationale: