Skip to content

Conversation

spencer-tb
Copy link
Contributor

@spencer-tb spencer-tb commented Sep 19, 2025

Description

The current EIP-6110 implementation does not validate the deposit log length or internal ABI structure as required by the EIP specification. This causes EEST test failures where invalid deposit event errors are not distinctly caught for the appropriate reason.

Note this PR is here to aid a proper solution and prompt discussion.

Solution

This PR implements the deposit event layout validation as specified in EIP-6110's is_valid_deposit_event_data function, where the function returns False for incorrect validations.

  1. Log Length: Valiadate that the log length is exactly 576 bytes.
  2. Offset: Validate that ABI offsets match the required values.
  3. Size: Validate that field sizes match the required values.

Hive eest/consume-engine

Following this PR, the failing EIP-6110 tests now pass:
https://hive.ethpandaops.io/#/test/fusaka/1758204471-aa8d60fbce3ef54fecbaf57a3fd84ef3?page=1&testnumber=17831

Requires: ethereum/hive#1344

Alternative Option

This is not my preference but as an alternative solution we can note this spec mismatch within EEST and accept the current errors for the test:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Backlog
Development

Successfully merging this pull request may close these issues.

1 participant