Skip to content

Conversation

mattsse
Copy link
Collaborator

@mattsse mattsse commented Sep 19, 2025

No description provided.

assert!(result.is_ok());
}

#[cfg(feature = "op")]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be good to wrap it in a feature gated module so that the test and the usage statement need just one feature gate.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good point, done

@mattsse mattsse added C-test A change that impacts how or what we test A-op-reth Related to Optimism and op-reth labels Sep 19, 2025
@mattsse mattsse enabled auto-merge September 19, 2025 16:23
@mattsse mattsse disabled auto-merge September 22, 2025 09:39
@mattsse mattsse merged commit 3ebfd7a into main Sep 22, 2025
41 checks passed
@mattsse mattsse deleted the matt/add-sanity-test-for-tx-env-conversion branch September 22, 2025 09:39
@github-project-automation github-project-automation bot moved this from Backlog to Done in Reth Tracker Sep 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-op-reth Related to Optimism and op-reth C-test A change that impacts how or what we test
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants