chore: specialize send_raw_transaction_sync for op-reth with flashblocks support
#18586
+82
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Peponks9
requested review from
mattsse,
Rjected,
fgimenez and
gakonst
as code owners
mattsse
requested changes
Sep 20, 2025
Comment on lines
98
to
104
| while let Some(notification) = canonical_stream.next().await { | ||
| // First check flashblocks for faster confirmation (Optimism-specific) | ||
| if let Ok(Some(pending_block)) = this.pending_flashblock() { | ||
| let block_and_receipts = pending_block.into_block_and_receipts(); | ||
| if block_and_receipts.block.body().contains_transaction(&hash) { | ||
| if let Some(receipt) = this.transaction_receipt(hash).await? { | ||
| return Ok(receipt); |
There was a problem hiding this comment.
this await loop we need to change slightly because the canonical_stream and flashblocks are ticking at a different rate
what we want is a tokio::select! here where one branch is canonical_stream.next() and the other is a WatchStream::new using:
reth/crates/optimism/rpc/src/eth/mod.rs
Line 102 in ebe1a8b
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the specialization of
send_raw_transaction_syncfor Optimism (op-reth), adding flashblocks support for faster transaction confirmations, based on new feedback.Closes #18372