feat(jovian): track da footprint block limit. Update basefee calculation #18777
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theochap
requested review from
Rjected,
RomanHodulak,
fgimenez,
gakonst,
mattsse,
mediocregopher,
rkrasiuk and
yongkangc
as code owners
5 tasks
klkvr
reviewed
Sep 30, 2025
theochap
requested review from
DaniPopes,
joshieDo,
rakita and
shekhirin
as code owners
theochap
force-pushed
the
theo/track-da-footprint-block-limit
branch
8 times, most recently
from
19c426f to
94a9600
Compare
theochap
commented
Oct 13, 2025
| .with_transactions(CustomTxPriority { chain_id }), | ||
| )) | ||
| .network(OpNetworkBuilder::new(disable_txpool_gossip, !discovery_v4)) | ||
| .network(OpNetworkBuilder::new(disable_txpool_gossip, true)) |
There was a problem hiding this comment.
We'll need to refactor the OpNetworkBuilder to either allow to disable both discv4 and discv5 or remove this argument entirely and only rely on NetworkArgs below. We cannot turn off both discv4 and discv5 there, which made this test fail with an Addr already in use error
klkvr
reviewed
Oct 14, 2025
9 tasks
theochap
force-pushed
the
theo/track-da-footprint-block-limit
branch
2 times, most recently
from
5af8f85 to
bc4b06b
Compare
Co-authored-by: Matthias Seitz <matthias.seitz@outlook.de>
theochap
force-pushed
the
theo/track-da-footprint-block-limit
branch
from
064ff57 to
2c0717d
Compare
theochap
force-pushed
the
theo/track-da-footprint-block-limit
branch
from
2c0717d to
176ad99
Compare
klkvr
force-pushed
the
klkvr/bump-revm
branch
from
624ca0f to
508ffac
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR integrates the DA footprint block limit feature from the jovian hardfork in op-reth.
Close #18406
Rebased on main and #18999
TODOS
alloy-evmversion.op-alloy-evmversion.revm-inspectorsversion