feat: wait for new blocks when build is in progress #18831
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lean-apple
force-pushed
the
await-progress-block
branch
from
48cf7f9 to
c43faed
Compare
mattsse
requested changes
Oct 2, 2025
Comment on lines
55
to
56
| /// Signals when a block build is in progress | ||
| build_state_tx: watch::Sender<bool>, |
There was a problem hiding this comment.
what if use Option<FbInfo> here where FbInfo is parenthash + index + blocknumber
then we can easily check from the pendingblock pov if the Fb in progress is the next index
mattsse
previously requested changes
Oct 2, 2025
crates/optimism/rpc/src/eth/mod.rs
Outdated
Comment on lines
152
to
158
| if tokio::time::timeout(MAX_WAIT_DURATION, rx_clone.changed()).await.is_ok() { | ||
| let fresh = rx_clone.borrow(); | ||
| if let Some(block) = self.extract_matching_block(fresh.as_ref(), parent_hash) { | ||
| return Ok(Some(block)); | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
I think we can simplify this and only need to keep tokio::time::timeout(MAX_WAIT_DURATION, rx_clone.changed()).await
because borrow always returns the most recent value
mattsse
reviewed
Oct 2, 2025
|
It's good for another round of reviews @RomanHodulak :) |
RomanHodulak
force-pushed
the
await-progress-block
branch
from
756f1ca to
ffb1ea3
Compare
CarlBeek
added a commit
to CarlBeek/reth
that referenced
this pull request
Oct 10, 2025
* main: (280 commits) refactor: remove needless collect() calls in trie tests (paradigmxyz#18937) chore(grafana): use precompile address as legend (paradigmxyz#18913) perf(tree): worker pooling for storage in multiproof generation (paradigmxyz#18887) feat: wait for new blocks when build is in progress (paradigmxyz#18831) chore: align node_config threshold constant (paradigmxyz#18914) docs: duplicate comment in Eip4844PoolTransactionError (paradigmxyz#18858) ci: cache hive simulator images to reduce prepare-hive job time (paradigmxyz#18899) refactor: replace collect().is_empty() with next().is_none() in tests (paradigmxyz#18902) feat(provider): add get_account_before_block to ChangesetReader (paradigmxyz#18898) refactor(engine): separate concerns in on_forkchoice_updated for better maintainability (paradigmxyz#18661) chore(node): simplify EngineApiExt bounds by removing redundant constraints (paradigmxyz#18905) fix(trie): Reveal extension child when extension is last remaining child of a branch (paradigmxyz#18891) chore: make clippy happy (paradigmxyz#18900) chore: relax `ChainSpec` impls (paradigmxyz#18894) refactor: eliminate redundant allocation in precompile cache example (paradigmxyz#18886) fix(era-utils): fix off-by-one for Excluded end bound in process_iter (paradigmxyz#18731) docs: yellowpaper sections in consensus implementation (paradigmxyz#18881) feat(storage): read headers and transactions only from static files (paradigmxyz#18788) feat: Use generic `HeaderTy` for `reth db get static-file headers` (paradigmxyz#18870) fix: streamline payload conversion in custom engine API (paradigmxyz#18864) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #18799.