-
Notifications
You must be signed in to change notification settings - Fork 1.9k
feat(prune): Add MerkleChangeSets
segment
#18893
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(prune): Add MerkleChangeSets
segment
#18893
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One missing functionality that should be easy to fix, plus naming suggestion.
Question: when pruning runs, does it also update the pipeline sync checkpoint which is stored? Or how should the engine check what range of data is actually available to be used?
34e2b9f
to
9a6f0f0
Compare
Answer: The pipeline will run the pruner, then check its output and save it's checkpoint. reth/crates/prune/prune/src/pruner.rs Lines 214 to 221 in 1b9f9e2
|
Hmm, I think this is the pruning checkpoint though, which is different than the pipeline sync checkpoint. So probably I'll need to update how the bounds check is working for engine API... |
9a6f0f0
to
d9a253b
Compare
ChangeSets
segmentMerkleChangeSets
segment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
d9a253b
to
71936c3
Compare
Closes #18463
Adds a pruner for change sets.
Change sets are newly persisted in the database and need to be pruned along with the rest of the entities to preserve space on full nodes.