Skip to content

Conversation

fgimenez
Copy link
Member

@fgimenez fgimenez commented Oct 8, 2025

then cache key depends on latest hive master commit seen on the build. prepare-hive job goes from ~15m https://github.com/paradigmxyz/reth/actions/runs/18340183869 to 6m https://github.com/paradigmxyz/reth/actions/runs/18341295331 when the cache is available

@fgimenez fgimenez force-pushed the fgimenez/hive-image-build branch from 019eb39 to 314b376 Compare October 8, 2025 10:39
@fgimenez fgimenez marked this pull request as ready for review October 8, 2025 10:39
@fgimenez fgimenez added C-test A change that impacts how or what we test C-hivetest Used for labelling automated issues relating to hive test failures A-ci Related to github workflows or other build and lint tools and removed C-test A change that impacts how or what we test labels Oct 8, 2025
Copy link
Member

@Rjected Rjected left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool, this makes sense to me

@github-project-automation github-project-automation bot moved this from Backlog to In Progress in Reth Tracker Oct 8, 2025
@fgimenez fgimenez added this pull request to the merge queue Oct 8, 2025
Merged via the queue into main with commit c78378a Oct 8, 2025
43 checks passed
@fgimenez fgimenez deleted the fgimenez/hive-image-build branch October 8, 2025 15:09
@github-project-automation github-project-automation bot moved this from In Progress to Done in Reth Tracker Oct 8, 2025
CarlBeek added a commit to CarlBeek/reth that referenced this pull request Oct 10, 2025
* main: (280 commits)
  refactor: remove needless collect() calls in trie tests (paradigmxyz#18937)
  chore(grafana): use precompile address as legend (paradigmxyz#18913)
  perf(tree): worker pooling for storage in multiproof generation (paradigmxyz#18887)
  feat: wait for new blocks when build is in progress (paradigmxyz#18831)
  chore: align node_config threshold constant (paradigmxyz#18914)
  docs: duplicate comment in Eip4844PoolTransactionError (paradigmxyz#18858)
  ci: cache hive simulator images to reduce prepare-hive job time (paradigmxyz#18899)
  refactor: replace collect().is_empty() with next().is_none() in tests (paradigmxyz#18902)
  feat(provider): add get_account_before_block to ChangesetReader (paradigmxyz#18898)
  refactor(engine): separate concerns in on_forkchoice_updated for better maintainability (paradigmxyz#18661)
  chore(node): simplify EngineApiExt bounds by removing redundant constraints (paradigmxyz#18905)
  fix(trie): Reveal extension child when extension is last remaining child of a branch (paradigmxyz#18891)
  chore: make clippy happy (paradigmxyz#18900)
  chore: relax `ChainSpec` impls (paradigmxyz#18894)
  refactor: eliminate redundant allocation in precompile cache example (paradigmxyz#18886)
  fix(era-utils): fix off-by-one for Excluded end bound in process_iter (paradigmxyz#18731)
  docs: yellowpaper sections in consensus implementation (paradigmxyz#18881)
  feat(storage): read headers and transactions only from static files (paradigmxyz#18788)
  feat: Use generic `HeaderTy` for `reth db get static-file headers` (paradigmxyz#18870)
  fix: streamline payload conversion in custom engine API (paradigmxyz#18864)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-ci Related to github workflows or other build and lint tools C-hivetest Used for labelling automated issues relating to hive test failures

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants