Skip to content

Conversation

lean-apple
Copy link
Contributor

@lean-apple lean-apple commented Oct 8, 2025

Attempt to make clippy happy and to fix

error: unnecessary parentheses
    --> crates/storage/provider/src/providers/blockchain_provider.rs:2275:71
     |
2275 |                   call_method!($arg_count, provider, $method, |_,_,_,_| ( ($invalid_args, None)), tx_num, tx_hash, &in_memory_blocks[0], &r...
     |                                                                         ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove them: `($invalid_args, None)`
...
2296 | /         test_non_range!([
2297 | |             (
2298 | |                 ONE,
2299 | |                 header,
...    |
2523 | |         ]);
     | |__________- in this macro invocation
     |
     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens
     = note: `-D clippy::double-parens` implied by `-D warnings`
     = help: to override `-D warnings` add `#[allow(clippy::double_parens)]`
     = note: this error originates in the macro `test_non_range` (in Nightly builds, run with -Z macro-backtrace for more info)

error: unnecessary parentheses
    --> crates/storage/provider/src/providers/blockchain_provider.rs:2286:80
     |
2286 |                   call_method!($arg_count, provider.database, $method, |_,_,_,_| ( (args, None)), tx_num, tx_hash, last_mem_block, &receipts);
     |                                                                                  ^^^^^^^^^^^^^^^ help: remove them: `(args, None)`
...

Copy link
Member

@fgimenez fgimenez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx!

@github-project-automation github-project-automation bot moved this from Backlog to In Progress in Reth Tracker Oct 8, 2025
@lean-apple lean-apple marked this pull request as ready for review October 8, 2025 07:55
@fgimenez fgimenez added this pull request to the merge queue Oct 8, 2025
Merged via the queue into paradigmxyz:main with commit b82ad07 Oct 8, 2025
44 checks passed
@github-project-automation github-project-automation bot moved this from In Progress to Done in Reth Tracker Oct 8, 2025
@lean-apple lean-apple deleted the clippy-happy branch October 8, 2025 12:01
CarlBeek added a commit to CarlBeek/reth that referenced this pull request Oct 10, 2025
* main: (280 commits)
  refactor: remove needless collect() calls in trie tests (paradigmxyz#18937)
  chore(grafana): use precompile address as legend (paradigmxyz#18913)
  perf(tree): worker pooling for storage in multiproof generation (paradigmxyz#18887)
  feat: wait for new blocks when build is in progress (paradigmxyz#18831)
  chore: align node_config threshold constant (paradigmxyz#18914)
  docs: duplicate comment in Eip4844PoolTransactionError (paradigmxyz#18858)
  ci: cache hive simulator images to reduce prepare-hive job time (paradigmxyz#18899)
  refactor: replace collect().is_empty() with next().is_none() in tests (paradigmxyz#18902)
  feat(provider): add get_account_before_block to ChangesetReader (paradigmxyz#18898)
  refactor(engine): separate concerns in on_forkchoice_updated for better maintainability (paradigmxyz#18661)
  chore(node): simplify EngineApiExt bounds by removing redundant constraints (paradigmxyz#18905)
  fix(trie): Reveal extension child when extension is last remaining child of a branch (paradigmxyz#18891)
  chore: make clippy happy (paradigmxyz#18900)
  chore: relax `ChainSpec` impls (paradigmxyz#18894)
  refactor: eliminate redundant allocation in precompile cache example (paradigmxyz#18886)
  fix(era-utils): fix off-by-one for Excluded end bound in process_iter (paradigmxyz#18731)
  docs: yellowpaper sections in consensus implementation (paradigmxyz#18881)
  feat(storage): read headers and transactions only from static files (paradigmxyz#18788)
  feat: Use generic `HeaderTy` for `reth db get static-file headers` (paradigmxyz#18870)
  fix: streamline payload conversion in custom engine API (paradigmxyz#18864)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants