Skip to content

Conversation

radik878
Copy link
Contributor

@radik878 radik878 commented Oct 8, 2025

  • Removed duplicated IntoEngineApiRpcModule + Send + Sync bounds from B::EngineApi in EngineApiExt since EngineApiBuilder already guarantees them.
  • Kept only B::EngineApi: Clone, which is required to pass the API value into the callback.

This reduces redundancy, unused import

@github-project-automation github-project-automation bot moved this from Backlog to In Progress in Reth Tracker Oct 8, 2025
@klkvr klkvr enabled auto-merge October 8, 2025 11:38
@klkvr klkvr added this pull request to the merge queue Oct 8, 2025
Merged via the queue into paradigmxyz:main with commit 1aa312c Oct 8, 2025
42 checks passed
@github-project-automation github-project-automation bot moved this from In Progress to Done in Reth Tracker Oct 8, 2025
CarlBeek added a commit to CarlBeek/reth that referenced this pull request Oct 10, 2025
* main: (280 commits)
  refactor: remove needless collect() calls in trie tests (paradigmxyz#18937)
  chore(grafana): use precompile address as legend (paradigmxyz#18913)
  perf(tree): worker pooling for storage in multiproof generation (paradigmxyz#18887)
  feat: wait for new blocks when build is in progress (paradigmxyz#18831)
  chore: align node_config threshold constant (paradigmxyz#18914)
  docs: duplicate comment in Eip4844PoolTransactionError (paradigmxyz#18858)
  ci: cache hive simulator images to reduce prepare-hive job time (paradigmxyz#18899)
  refactor: replace collect().is_empty() with next().is_none() in tests (paradigmxyz#18902)
  feat(provider): add get_account_before_block to ChangesetReader (paradigmxyz#18898)
  refactor(engine): separate concerns in on_forkchoice_updated for better maintainability (paradigmxyz#18661)
  chore(node): simplify EngineApiExt bounds by removing redundant constraints (paradigmxyz#18905)
  fix(trie): Reveal extension child when extension is last remaining child of a branch (paradigmxyz#18891)
  chore: make clippy happy (paradigmxyz#18900)
  chore: relax `ChainSpec` impls (paradigmxyz#18894)
  refactor: eliminate redundant allocation in precompile cache example (paradigmxyz#18886)
  fix(era-utils): fix off-by-one for Excluded end bound in process_iter (paradigmxyz#18731)
  docs: yellowpaper sections in consensus implementation (paradigmxyz#18881)
  feat(storage): read headers and transactions only from static files (paradigmxyz#18788)
  feat: Use generic `HeaderTy` for `reth db get static-file headers` (paradigmxyz#18870)
  fix: streamline payload conversion in custom engine API (paradigmxyz#18864)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants