feat: add TRACE level spans for payload validation #18911
Closed
+67
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
futreall
requested review from
Rjected,
fgimenez,
mattsse,
mediocregopher,
rkrasiuk and
yongkangc
as code owners
|
Thanks for the PR, I assigned myself to this issue because I'm working on it myself right now 😅 Feel free to take any issues that don't have an assignee! |
|
Oops, sorry, I didn't notice. I’ll be more attentive next time, thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Added 6 spans covering all validation stages:
payload_validation- parent span for the whole processpre_execution_validation- consensus validationprewarming- processor warmupevm_execution- block executionstate_root_computation- state root calculationpost_execution_validation- final validationAll spans use
target: "engine::tree"and include block metadata for easier debugging.Fixes #18892