fix(trie): fix trie changesets checkpoint handling #18922
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mediocregopher
requested review from
joshieDo,
rakita and
shekhirin
as code owners
Rjected
reviewed
Oct 10, 2025
| // If the finalized block was way in the past then we don't want to generate changesets for | ||
| // all of those past blocks; we only care about the recent history. | ||
| // | ||
| // Use maximum of finalized_block and retention_based_start if finalized_block exists, |
There was a problem hiding this comment.
This says maximum but the code still uses min?
There was a problem hiding this comment.
good catch, i don't know how I missed this 🤦
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #18903
Fixes the two bugs described in that ticket