refactor: HashedPostStateCursors
#18930
Open
+71
−61
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Modify HashedPostStateAccountCursor and HashedPostStateStorageCursor to use the new sorted vectors. - Replace HashSet lookups with binary search on sorted Vecs. - Adjust seek_inner, next_inner, and helper methods for Option-based handling.
Peponks9
requested review from
Rjected,
mediocregopher,
rkrasiuk and
shekhirin
as code owners
|
Hey @Peponks9 , thanks for the PR. This doesn't quite do what the issue asks for, we are looking to get rid of the |
Peponks9
commented
Oct 10, 2025
There was a problem hiding this comment.
howdy @mediocregopher thanks for the feedback, will take a closer look at the pr and continue to work towards this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
HashedPostStateSortedstructures: updatedHashedAccountsSortedand HashedStorageSortedto use a singleVec<(B256, Option<...>)>` for accounts/storage, with sorted vectors and lookup via binary search algo.HashedPostStateAccountCursorandHashedPostStateStorageCursorto iterate over the vectors, eliminatingHashSetdepsCloses #18848