[wip] feat(osaka): convert blobs around transition #19056
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Your PR title doesn't follow the Conventional Commit guidelines. Example of valid titles:
Usage:
Breaking Changes Breaking changes are noted by using an exclamation mark. For example:
Help For more information, follow the guidelines here: https://www.conventionalcommits.org/en/v1.0.0/ |
mattsse
requested changes
Oct 15, 2025
Collaborator
mattsse
left a comment
mattsse
left a comment
There was a problem hiding this comment.
in order for this to be reachable we also need to disable the check in validator itself because this currently enforce pre vs post sidecar versions
klkvr
force-pushed
the
klkvr/convert-blobs
branch
from
77b2a0c to
39ef247
Compare
mattsse
reviewed
Oct 16, 2025
Comment on lines
+444
to
+461
| // collect a vec of transactions that need to be added to the pool | ||
| let (ready_results, to_add): (Vec<_>, Vec<_>) = txs | ||
| .into_iter() | ||
| .map(|(origin, tx)| match tx { | ||
| TransactionValidationOutcome::Valid { | ||
| transaction: | ||
| ValidTransaction::ValidWithSidecar { | ||
| transaction, | ||
| sidecar: | ||
| PoolTransactionSidecar::Eip4844 { sidecar, should_convert: true }, | ||
| }, | ||
| .. | ||
| } => { | ||
| let this = self.clone(); | ||
| let hash = *transaction.hash(); | ||
| tokio::task::spawn(async move { | ||
| let Some(converted) = | ||
| this.pool.blob_sidecar_converter().convert(sidecar).await |
Collaborator
There was a problem hiding this comment.
this feels a bit weird because we don't really ensure that we actually add the transaction if I understand this correctly
Collaborator
|
superseded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.