Skip to content

Conversation

@zeevick10
Copy link
Contributor

Description

  • Summary: Remove apt-get -y upgrade from the build stage in Dockerfile.
  • Why: Avoid non-deterministic builds, reduce cache busting, and speed up image builds.
  • Change: Replace RUN apt-get update && apt-get -y upgrade && apt-get install -y ... with RUN apt-get update && apt-get install -y ....

Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this has been working fine but I do the the upgrade isnt necessary here?
@shekhirin ?

@mattsse mattsse requested a review from shekhirin October 17, 2025 10:05
Copy link
Collaborator

@shekhirin shekhirin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, not necessary.

@github-project-automation github-project-automation bot moved this from Backlog to In Progress in Reth Tracker Oct 31, 2025
@shekhirin shekhirin added this pull request to the merge queue Oct 31, 2025
@shekhirin shekhirin added C-debt A clean up/refactor of existing code A-ci Related to github workflows or other build and lint tools labels Oct 31, 2025
Merged via the queue into paradigmxyz:main with commit d8729a9 Oct 31, 2025
42 checks passed
@github-project-automation github-project-automation bot moved this from In Progress to Done in Reth Tracker Oct 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-ci Related to github workflows or other build and lint tools C-debt A clean up/refactor of existing code

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants