Skip to content

ci: verify geth tarball checksum before extraction #19081

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

ci: verify geth tarball checksum before extraction #19081

wants to merge 1 commit into from

Conversation

@zeevick10
Copy link
Contributor

@zeevick10 zeevick10 commented Oct 16, 2025 •
edited
Loading

Description

  • Summary: Add SHA256 verification to .github/assets/install_geth.sh before extracting the tarball.
  • Change: Download *.sha256 and run sha256sum -c prior to tar -xvf.
  • Why: Reduce supply-chain risk and prevent corrupted/altered artifacts from running in CI.

@github-project-automation github-project-automation bot moved this to Backlog in Reth Tracker Oct 16, 2025
@zeevick10 zeevick10 changed the title ci: verify geth tarball checksum and remove apt-get upgrade ci: verify geth tarball checksum before extraction Oct 16, 2025
mattsse
mattsse reviewed Oct 16, 2025
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we only run this in ci so we dont need this

@mattsse mattsse closed this Oct 16, 2025
@github-project-automation github-project-automation bot moved this from Backlog to Done in Reth Tracker Oct 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mattsse mattsse mattsse left review comments

@gakonst gakonst Awaiting requested review from gakonst gakonst is a code owner

@DaniPopes DaniPopes Awaiting requested review from DaniPopes DaniPopes is a code owner

Assignees

No one assigned

Labels

None yet

Projects

Reth Tracker
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@zeevick10 @mattsse