Skip to content

Conversation

klkvr
Copy link
Member

@klkvr klkvr commented Oct 16, 2025

No description provided.

@klkvr klkvr force-pushed the klkvr/convert-blobs-rpc branch from 6a91115 to 459cda6 Compare October 16, 2025 12:32
@klkvr klkvr changed the title [wip] feat: convert blobs at RPC feat: convert blobs at RPC Oct 16, 2025
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

as discussed one suggestion re osaka activation check

@github-project-automation github-project-automation bot moved this from Backlog to In Progress in Reth Tracker Oct 17, 2025
@mattsse mattsse marked this pull request as ready for review October 17, 2025 09:19
@mattsse mattsse added M-changelog This change should be included in the changelog A-rpc Related to the RPC implementation E-osaka Related to the Osaka network upgrade labels Oct 17, 2025
.provider()
.latest_header()?
.ok_or(EthApiError::HeaderNotFound(BlockId::latest()))?;
if self.provider().chain_spec().is_osaka_active_at_timestamp(latest.timestamp())
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we also use latest.timestamp() + 12 or 20 here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changed to start converting 12s before in f88ddd9 but I think it should anyway be fine because any legacy sidecars we accept will end up handled by #19095

@klkvr klkvr added this pull request to the merge queue Oct 17, 2025
Merged via the queue into main with commit ca26219 Oct 17, 2025
41 checks passed
@github-project-automation github-project-automation bot moved this from In Progress to Done in Reth Tracker Oct 17, 2025
@klkvr klkvr deleted the klkvr/convert-blobs-rpc branch October 17, 2025 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-rpc Related to the RPC implementation E-osaka Related to the Osaka network upgrade M-changelog This change should be included in the changelog

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants