-
Notifications
You must be signed in to change notification settings - Fork 1.9k
feat: convert blobs at RPC #19084
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: convert blobs at RPC #19084
Conversation
6a91115
to
459cda6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
as discussed one suggestion re osaka activation check
.provider() | ||
.latest_header()? | ||
.ok_or(EthApiError::HeaderNotFound(BlockId::latest()))?; | ||
if self.provider().chain_spec().is_osaka_active_at_timestamp(latest.timestamp()) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we also use latest.timestamp() + 12 or 20 here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No description provided.