feat: convert pooled blobs transition #19095
Merged
+251
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattsse
reviewed
Oct 16, 2025
| let pool = pool.clone(); | ||
| let spawner = task_spawner.clone(); | ||
| let client = client.clone(); | ||
| task_spawner.spawn(Box::pin(async move { |
There was a problem hiding this comment.
could we perhaps make this a standalone fn, feel like this would be easier to delete later, but maybe doesnt really matter
| } | ||
| // Remove transaction and sidecar from the pool, both are in memory | ||
| // now | ||
| let Some(tx) = pool.remove_transactions(vec![tx_hash]).pop() else { |
There was a problem hiding this comment.
let me add a new api fn for this
Comment on lines
+511
to
+522
| let last_iteration = | ||
| client.latest_header().ok().flatten().is_none_or(|header| { | ||
| client | ||
| .chain_spec() | ||
| .is_osaka_active_at_timestamp(header.timestamp()) | ||
| }); |
There was a problem hiding this comment.
this exit condition assumes we're making it past the block, if that doesn't happen this loop will keep going, but since we have the timeout this is fine
klkvr
force-pushed
the
klkvr/convert-blobs-transition
branch
from
dbdb714 to
178b2e0
Compare
klkvr
changed the title
klkvr
requested review from
RomanHodulak,
fgimenez and
gakonst
as code owners
klkvr
force-pushed
the
klkvr/convert-blobs-transition
branch
from
178b2e0 to
8b7b074
Compare
mattsse
approved these changes
Oct 17, 2025
Comment on lines
+508
to
+511
| // Start converting not eaerlier than 4 seconds into current slot to ensure | ||
| // that our pool only contains valid transactions for the next block (as | ||
| // it's not Osaka yet). | ||
| tokio::time::sleep(Duration::from_secs(4)).await; |
mattsse
added
M-changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #19084