fix: resolve nonce validation error in debug_executionWitness for pruned nodes #19346
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hawkadrian
requested review from
Rjected,
RomanHodulak and
mattsse
as code owners
mattsse
reviewed
Oct 31, 2025
crates/rpc/rpc/src/debug.rs
Outdated
Comment on lines
658
to
660
| // Apply pre-execution changes to ensure correct state setup, especially for pruned | ||
| // nodes | ||
| this.eth_api().apply_pre_execution_changes(&block, &mut db, &evm_env)?; |
Collaborator
There was a problem hiding this comment.
I dont think this is correct because the actual
block_executor.execute_with_state_closure
call already takes care of that
Contributor
Author
There was a problem hiding this comment.
I dont think this is correct because the actual
block_executor.execute_with_state_closurecall already takes care of that
I've removed the redundant call as you suggested.
Just to confirm - does execute_block handle EIP-4788 system calls as well? The RPC apply_pre_execution_changes specifically handles the 4788 system call for beacon root updates. If the issue persists, should we investigate elsewhere?
Collaborator
There was a problem hiding this comment.
yes execute handles the entire block STF including pre+post system calls,
this is like an issue with pruned state, worth opening an issue of this, but we dont need to fix anything here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes nonce validation error in
debug_executionWitnesswhen used with pruned nodes.Problem
The
debug_executionWitnessRPC method was failing with "nonce too high" error when used on pruned nodes. This occurred because the method was not applying pre-execution changes to properly set up the state before block execution.Solution
Added missing
apply_pre_execution_changescall indebug_execution_witness_for_blockmethod, following the same pattern used by other debug methods likedebug_trace_transaction.Fixes #19244