feat(tracing-otlp): make trace id ratio sample customizable with --tracing-otlp.sample-ratio arg
#19438
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lean-apple
changed the title
--tracing-otlp-sampler-ratio arg--tracing-otlp-sampler-ratio arg
lean-apple
changed the title
--tracing-otlp-sampler-ratio arg--tracing-otlp-sampler-ratio arg
lean-apple
changed the title
--tracing-otlp-sampler-ratio arg--tracing-otlp-sample-ratio arg
lean-apple
requested review from
Rjected,
fgimenez,
gakonst,
klkvr and
mattsse
as code owners
lean-apple
changed the title
--tracing-otlp-sample-ratio arg--tracing-otlp.sample-ratio arg
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Member
|
@lean-apple do you mind rebasing and running |
Contributor
Author
Sure, it should be ok now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #19282.
Add a new arg
--tracing-otlp.sample-ratioto enable to configure the ratio of traces exportedAdd
OtlpConfigto avoid the long list of args for some functions