Skip to content

fix: ensure transaction lookup can prune #19553

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
+374 −65
Open

fix: ensure transaction lookup can prune #19553

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
718feb9
ensure txlookup can prune
joshieDo Nov 6, 2025
5c00ece
fix checkpoint & prune what we can
joshieDo Nov 7, 2025
e579429
make sure we dont get stuck on prune pipeline stage
joshieDo Nov 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions crates/prune/prune/src/segments/set.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,8 +72,10 @@ where
} = prune_modes;

Self::default()
// Bodies - run first since file deletion is fast
.segment_opt(bodies_history.map(Bodies::new))
// Transaction lookup (should be run before bodies)
.segment_opt(transaction_lookup.map(TransactionLookup::new))
// Bodies
.segment_opt(bodies_history.map(|mode| Bodies::new(mode, transaction_lookup)))
Comment on lines +75 to +78
Copy link
Collaborator

@mattsse mattsse Nov 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we add more note for dummies: because we still need bodies for txlookup

// Merkle changesets
.segment(MerkleChangeSets::new(merkle_changesets))
// Account history
Expand All @@ -82,8 +84,6 @@ where
.segment_opt(storage_history.map(StorageHistory::new))
// User receipts
.segment_opt(receipts.map(UserReceipts::new))
// Transaction lookup
.segment_opt(transaction_lookup.map(TransactionLookup::new))
// Sender recovery
.segment_opt(sender_recovery.map(SenderRecovery::new))
}
Expand Down
Loading