feat(engine): batch multiproof messages #19603
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xSooki
requested review from
Rjected,
fgimenez,
mattsse,
mediocregopher and
yongkangc
as code owners
Collaborator
|
@0xSooki looks like e2e tests are failing, can you take a look at why that might be? You should be able to run them locally, no need to wait for CI to find out if they're fixed or not. |
Author
|
Absolutely, working on it. |
Author
|
@mediocregopher done |
mediocregopher
requested changes
Nov 24, 2025
| num_batched += 1; | ||
| } | ||
| Ok(other_msg) => { | ||
| let _ = self.tx.send(other_msg); |
Collaborator
There was a problem hiding this comment.
If this message is a MultiProofMessage::StateUpdate, then I believe this will result in state updates being consumed in the incorrect order. Currently they must be consumed in the order they were produced, as that ultimately determines their sequence number and therefore the order they get sent to the state root task.
If there is a way to push to the front of a crossbeam channel then some kind of buffer local to function will need to be used.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #19168
Batching additions:
PrefetchProofsmessagesStateUpdatemessagesTesting enhancements:
test_prefetch_proofs_batchingto verify that multiplePrefetchProofsmessages are correctly batched and processed as a single unit.test_state_update_batchingto ensure that multipleStateUpdatemessages are merged and handled together as intended.