feat: add support for eip-7872 Max blob flag for local builders #19614
+44
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevencartavia
requested review from
Rjected,
gakonst,
klkvr and
mattsse
as code owners
mattsse
requested changes
Nov 10, 2025
crates/ethereum/payload/src/lib.rs
Outdated
Comment on lines
201
to
202
| let protocol_max_blob_count = | ||
| blob_params.as_ref().map(|params| params.max_blob_count).unwrap_or_default(); |
Collaborator
There was a problem hiding this comment.
can we move this into unwrap_or_else
|
|
||
| /// Maximum number of blobs to include per block. | ||
| #[arg(long = "builder.max-blobs", value_name = "COUNT")] | ||
| pub max_blobs_per_block: Option<u8>, |
Collaborator
There was a problem hiding this comment.
this will (hopefully) eventually exceed 256, so we can just make this a u64 instead, then we can avoid type casts
crates/ethereum/payload/src/lib.rs
Outdated
| // Apply user-configured blob limit (EIP-7872) | ||
| let max_blob_count = builder_config | ||
| .max_blobs_per_block | ||
| .map(|user_limit| std::cmp::min(user_limit as u64, protocol_max_blob_count).max(1)) |
Collaborator
There was a problem hiding this comment.
is max(1) part of the eip? that this can't be lower than that?
1 doesnt really make much sense really, so imo 0 is also a valid value here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #19613