Skip to content

feat: add benchmarks for js-tracer #313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

feat: add benchmarks for js-tracer #313

wants to merge 4 commits into from

Conversation

mattsse
Copy link
Contributor

@mattsse mattsse commented Jul 10, 2025

Summary

Adds comprehensive benchmarks for js-tracer performance testing to help measure and optimize performance.

Changes

  • Added Criterion benchmarks for various js-tracer scenarios:
    • Simple step counter
    • Database access operations
    • Heavy operations (collecting multiple fields)
    • Memory operations
    • Stack operations
    • Enter/exit frame tracking
  • Added profiling binary for generating flamegraphs

Usage

# Run benchmarks
cargo bench --bench js_tracer --features js-tracer

# Generate flamegraph (requires cargo-flamegraph or samply)
cargo build --bench js_tracer_profile --features js-tracer --release
samply record target/release/deps/js_tracer_profile-*

These benchmarks will help measure the performance impact of future optimizations to the js-tracer, particularly around object reuse.

🤖 Generated with Claude Code

@mattsse @claude
feat: add benchmarks for js-tracer
cef9cbe 
Adds comprehensive benchmarks for js-tracer performance testing:
- Simple step counter
- Database access operations
- Heavy operations (collecting multiple fields)
- Memory operations
- Stack operations
- Enter/exit frame tracking

Also includes a profiling binary for generating flamegraphs.

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
@mattsse mattsse requested a review from DaniPopes as a code owner July 10, 2025 12:50
mattsse and others added 3 commits July 10, 2025 14:52
@mattsse
fmt
03ca577
@mattsse
fix: allow missing docs and dead code in benchmarks
0acf222 
Add #![allow(missing_docs)] to both benchmark files to suppress documentation warnings.
Add #![allow(dead_code)] to js_tracer_profile.rs for unused profile functions.
@DaniPopes
Merge branch 'main' into bench/js-tracer-benchmarks
54cab7e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DaniPopes DaniPopes Awaiting requested review from DaniPopes DaniPopes is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mattsse @DaniPopes