ABI output should include referenced events, not just defined

[DaniPopes]

Describe the feature

Contract ABI output should include events and custom errors referenced in the contract, even if not defined in the contract/inheritance.

For example, an event defined in the global scope and emitted in the constructor or any function will not currently be recorded.

In practice it's not that big of a deal if this is missing, however we should match the solc output which does this.

This requires type checking and a resolved call graph.

Additional context

• TODO link:

  solar/crates/sema/src/ty/abi.rs

  Lines 44 to 45 in 53b2b1a

  	// TODO: Does not include referenced items.
  	// See solc `interfaceEvents` and `interfaceErrors`.

• solc interfaceEvents: https://github.com/ethereum/solidity/blob/7ef0ef8c19bf7df4341b3e72787d8ac75cf988e6/libsolidity/ast/AST.cpp#L250

[MuhtasimTanmoy]

• Contract Counter.sol

// SPDX-License-Identifier: MIT
pragma solidity ^0.8.0;

// Define an event in the global scope
event GlobalEvent(address indexed sender, uint256 value);

// Contract that references the global event
contract EventEmitter {
    // Constructor that emits the global event
    constructor(uint256 initialValue) {
        emit GlobalEvent(msg.sender, initialValue);
    }

    // Function that emits the global event
    function triggerEvent(uint256 value) public {
        emit GlobalEvent(msg.sender, value);
    }
}

• Current output (solar ):

// solar Counter.sol --emit abi

{
  "contracts": {
    "/path/Event.sol:EventEmitter": {
      "abi": [
        {
          "type": "constructor",
          "inputs": [
            {
              "name": "initialValue",
              "type": "uint256",
              "internalType": "uint256"
            }
          ],
          "stateMutability": "nonpayable"
        },
        {
          "type": "function",
          "name": "triggerEvent",
          "inputs": [
            {
              "name": "value",
              "type": "uint256",
              "internalType": "uint256"
            }
          ],
          "outputs": [],
          "stateMutability": "nonpayable"
        }
      ]
    }
  },
  "version": "0.1.2"
}

Expected output (solc ):

 // solc --abi Counter.sol

[
    {
      "inputs": [
        {
          "internalType": "uint256",
          "name": "initialValue",
          "type": "uint256"
        }
      ],
      "stateMutability": "nonpayable",
      "type": "constructor"
    },
    {
      "anonymous": false,
      "inputs": [
        {
          "indexed": true,
          "internalType": "address",
          "name": "sender",
          "type": "address"
        },
        {
          "indexed": false,
          "internalType": "uint256",
          "name": "value",
          "type": "uint256"
        }
      ],
      "name": "GlobalEvent",
      "type": "event"
    },
    {
      "inputs": [
        {
          "internalType": "uint256",
          "name": "value",
          "type": "uint256"
        }
      ],
      "name": "triggerEvent",
      "outputs": [],
      "stateMutability": "nonpayable",
      "type": "function"
    }
  ]

This is the expected behaviour after fix, right?

[DaniPopes]

That's right

[MuhtasimTanmoy]

Ok. Thanks. Going for it.

[DaniPopes]

This is blocked on further work on the front end, it cannot be implemented right now :)

[MuhtasimTanmoy]

Blocked on which issue?

[SWASTIC-7]

@DaniPopes is it still blocked, else i would like to take this up?