WIP: css variable calc minification#526
Draft
MoritzLoewenstein wants to merge 3 commits intoparcel-bundler:masterfrom
Draft
WIP: css variable calc minification#526MoritzLoewenstein wants to merge 3 commits intoparcel-bundler:masterfrom
MoritzLoewenstein wants to merge 3 commits intoparcel-bundler:masterfrom
Conversation
68a1bff to
3930139
Compare
Contributor
|
Is it possible to just take the logic from |
Author
|
Possibly? If you want, you can try that approach, I was struggling to implement the more useful transforms because I dont have any rust experience anyways. P.S.: Was also struggling with the general approach, how to make it "understand" the math expression without doing too much work. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trying to implement the following cases:
calcwith one argument, just keep inner token.to
2.
calcinside anothercalc, inner calc can be converted to parenthesis tokens.to
3. simplify
calcwith multiple tokens of the same unit(px, deg etc)to
4. simplify parenthesis expression with multiple tokens of the same unit(px, deg etc)
to
5. remove parenthesis around a single token inside a calc expression
to