test: Use Vitest as test runner #967
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drwpow
force-pushed
the
drwpow/vitest
branch
2 times, most recently
from
5893b98 to
bf10958
Compare
drwpow
commented
Apr 21, 2025
| }, | ||
| }, | ||
|
|
||
| // TODO: enable for browser tests |
There was a problem hiding this comment.
Note: I was able to get the browser tests set up locally, but it (correctly) errs on
module "browserslistToTargets.js" declares no export named "browserslistToTargets"
as it’s CJS, attempting to run as an ESM import. I don’t want to touch any runtime with a 10' pole, especially not in this PR, so maybe there’s a way we could build this file or something just to get the proper behavior in tests.
drwpow
commented
Apr 21, 2025
| @@ -5,6 +5,7 @@ | |||
| "moduleResolution": "node", | |||
| "isolatedModules": true, | |||
| "noEmit": true, | |||
| "strict": true | |||
| "strict": true, | |||
| "skipLibCheck": true | |||
There was a problem hiding this comment.
Necessary for Vitest, unfortunately 😕. But also, this is fine to add IMO as this PR does add more typechecking to tests (we likely would have hit this at some point anyway adding more typechecking).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft PR as part of #965, just to show suggested starting point