Skip to content

Commit 149c709

Browse files
rzadpshawntabriziggwpez
authored
Add missing features in templates' node packages (#5294)
Corrects the issue we had [here](paritytech/polkadot-sdk-parachain-template#10), in which `cargo build --release` worked but `cargo build --package parachain-template-node --release` failed with missing features. The command has been added to CI to make sure it works, but at the same we're changing it in the readme to just `cargo build --release` for simplification. Labeling silent because those packages are un-published as part of the regular release process. --------- Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> Co-authored-by: Shawn Tabrizi <shawntabrizi@gmail.com> Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
1 parent 47c1b4c commit 149c709

File tree

6 files changed

+17
-6
lines changed

6 files changed

+17
-6
lines changed

templates/minimal/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ packages required to compile this template - please take note of the Rust compil
4242
🔨 Use the following command to build the node without launching it:
4343

4444
```sh
45-
cargo build --package minimal-template-node --release
45+
cargo build --release
4646
```
4747

4848
🐳 Alternatively, build the docker image:

templates/minimal/node/Cargo.toml

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -57,4 +57,7 @@ minimal-template-runtime = { workspace = true }
5757
substrate-build-script-utils = { workspace = true, default-features = true }
5858

5959
[features]
60-
default = []
60+
default = ["std"]
61+
std = [
62+
"minimal-template-runtime/std",
63+
]

templates/parachain/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ packages required to compile this template - please take note of the Rust compil
4444
🔨 Use the following command to build the node without launching it:
4545

4646
```sh
47-
cargo build --package parachain-template-node --release
47+
cargo build --release
4848
```
4949

5050
🐳 Alternatively, build the docker image:

templates/parachain/node/Cargo.toml

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,12 @@ color-print = { workspace = true }
7979
substrate-build-script-utils = { workspace = true, default-features = true }
8080

8181
[features]
82-
default = []
82+
default = ["std"]
83+
std = [
84+
"log/std",
85+
"parachain-template-runtime/std",
86+
"xcm/std",
87+
]
8388
runtime-benchmarks = [
8489
"cumulus-primitives-core/runtime-benchmarks",
8590
"frame-benchmarking-cli/runtime-benchmarks",

templates/solochain/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ installation](#alternatives-installations) options.
2828
Use the following command to build the node without launching it:
2929

3030
```sh
31-
cargo build --package solochain-template-node --release
31+
cargo build --release
3232
```
3333

3434
### Embedded Docs

templates/solochain/node/Cargo.toml

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,10 @@ solochain-template-runtime = { workspace = true }
6666
substrate-build-script-utils = { workspace = true, default-features = true }
6767

6868
[features]
69-
default = []
69+
default = ["std"]
70+
std = [
71+
"solochain-template-runtime/std",
72+
]
7073
# Dependencies that are only required if runtime benchmarking should be build.
7174
runtime-benchmarks = [
7275
"frame-benchmarking-cli/runtime-benchmarks",

0 commit comments

Comments
 (0)