feat: Add support for visionOS#1762
Open
bmueller wants to merge 14 commits intoparse-community:masterfrom
Open
feat: Add support for visionOS#1762bmueller wants to merge 14 commits intoparse-community:masterfrom
bmueller wants to merge 14 commits intoparse-community:masterfrom
Conversation
Thanks for opening this pull request!
|
Member
|
@bmueller Thank you for the PR, everything looks good so far! Waiting for #1763 to be merged to fix the CI and to prevent any merge conflicts with this PR. The next steps would be:
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1762 +/- ##
=======================================
Coverage 64.24% 64.24%
=======================================
Files 201 201
Lines 23233 23233
=======================================
+ Hits 14926 14927 +1
+ Misses 8307 8306 -1 ☔ View full report in Codecov by Sentry. |
Member
|
@bmueller Would you want to add a visionOS job to the CI as well, so we can make sure it compiles? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New Pull Request Checklist
Issue Description
Adds visionOS support.
Closes: #1761
Approach
Just added TARGET_OS_VISION in a bunch of places. Also updated the readme to mention visionOS alongside the other supported platforms.
TODOs before merging