-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
feat: New option to make modal resizable #1885
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: alpha
Are you sure you want to change the base?
Conversation
Thanks for opening this pull request!
|
@mtrezza regarding labels being resized as well: I tried to force a |
That's fine then, thanks for looking into it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried it out and I wonder how we can combine the vertical and horizontal resizing by dragging the dialog corner. That the dialog can only be resized horizontally in the dialog corner and only vertically in the field corner is a rather unusual behavior.
There is also a bug that selects all text in the dialog when I resize horizontally:
Screen.Recording.2021-10-27.at.22.42.39.mov
@mtrezza Maybe instead of the drag handle in the corner, we could allow resizing the modal with both the left and right edge of the container. |
Not sure how the experience of that would be. I can only think of a corner drag handle, like the field had. That is the UI behavior a user would typically expect. If there is another way that is intuitive, we can also explore that. |
It could work as in a regular OS window manager, the whole side could be used to resize the modal: sideresizable.mov |
If it's separately resizable on the horizontal and vertical side it would certainly be an improvement over the status quo, but it would still be impractical when you cannot resize both simultaneously. I think that's an issue when want to resize because there is a large JSON object that you want to display and you want to fit the dialog just right to display it. What is the difficulty to let resize both at the same time? Is it a component restriction? |
I will reformat the title to use the proper commit message syntax. |
New Pull Request Checklist
Issue Description
This PR adds a "resize" handle to modals that have the
resizable
prop enabled.Closes: #1879
Approach
TODOs before merging