Skip to content

refactor: Upgrade apollo-upload-client from 17.0.0 to 18.0.1 #9031

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Oct 23, 2024
Merged

refactor: Upgrade apollo-upload-client from 17.0.0 to 18.0.1 #9031

merged 7 commits into from
Oct 23, 2024

Conversation

@Moumouls
Copy link
Member

@Moumouls Moumouls commented Mar 17, 2024 •
edited
Loading

Pull Request

Issue

Closes: #9009

Approach

Tasks

  • Add tests
  • Add changes to documentation (guides, repository pages, code comments)
  • Add security check
  • Add new Parse Error codes to Parse JS SDK

@parse-github-assistant
Copy link

I will reformat the title to use the proper commit message syntax.

@parse-github-assistant parse-github-assistant bot changed the title feat: upgrade apollo upload client feat: Upgrade apollo upload client Mar 17, 2024
@parse-github-assistant
Copy link

parse-github-assistant bot commented Mar 17, 2024 •
edited
Loading

Thanks for opening this pull request!

@codecov
Copy link

codecov bot commented Mar 17, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.49%. Comparing base (d3b7fb0) to head (8a5afaa).
Report is 1 commits behind head on alpha.

Additional details and impacted files 
@@            Coverage Diff             @@
##            alpha    #9031      +/-   ##
==========================================
+ Coverage   93.48%   93.49%   +0.01%     
==========================================
  Files         186      186              
  Lines       14812    14812              
==========================================
+ Hits        13847    13849       +2     
+ Misses        965      963       -2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mtrezza mtrezza changed the title feat: Upgrade apollo upload client refactor: Bump apollo-upload-client from 17.0.0 to 18.0.1 Mar 19, 2024
@mtrezza mtrezza changed the title refactor: Bump apollo-upload-client from 17.0.0 to 18.0.1 refactor: Upgrade apollo-upload-client from 17.0.0 to 18.0.1 Mar 19, 2024
mtrezza
mtrezza previously approved these changes Mar 20, 2024
View reviewed changes
Copy link
Member

@mtrezza mtrezza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@mtrezza
Copy link
Member

mtrezza commented Mar 20, 2024 •
edited
Loading

This requires at least Node 18.15, which is higher than the current min node engine version. We'll merge this in Parse Server 8 around Dec 2024.

@mtrezza mtrezza added block:major Needs to be resolved before next major release; remove label afterwards state:breaking Breaking change requires major version increment and `BREAKING CHANGE` commit message labels Mar 20, 2024
@parse-github-assistant
Copy link

The label block:major cannot be used here.

@parse-github-assistant parse-github-assistant bot removed the block:major Needs to be resolved before next major release; remove label afterwards label Mar 20, 2024
@mtrezza mtrezza added block:major Needs to be resolved before next major release; remove label afterwards and removed state:breaking Breaking change requires major version increment and `BREAKING CHANGE` commit message labels Mar 20, 2024
@parse-github-assistant
Copy link

The label block:major cannot be used here.

@parse-github-assistant parse-github-assistant bot removed the block:major Needs to be resolved before next major release; remove label afterwards label Mar 20, 2024
@Moumouls
Merge branch 'upstream/alpha' into moumouls/update-apollo-upload-client
8746e06 
# Conflicts:
#	package-lock.json
#	package.json
@Moumouls
Copy link
Member Author

flaky on mongo 7 it seems @mtrezza

@Moumouls Moumouls requested a review from a team October 23, 2024 17:04
@mtrezza
Copy link
Member

mtrezza commented Oct 23, 2024

We may merge this in Nov, when we start with Parse Server 8 preparations.

@Moumouls
Copy link
Member Author

@mtrezza if i remember the breaking stuff was about 6.X, for current alpha it should be okay to merge now.

@mtrezza
Copy link
Member

mtrezza commented Oct 23, 2024

I must have mixed up the browser tabs, thanks

@mtrezza mtrezza merged commit 412e724 into parse-community:alpha Oct 23, 2024
29 of 30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mtrezza mtrezza mtrezza left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Moumouls @mtrezza