Skip to content

refactor: Upgrade commander from 13.1.0 to 14.0.0 #9792

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: alpha
Choose a base branch
from

Conversation

parseplatformorg
Copy link
Contributor

@parseplatformorg parseplatformorg commented Jun 10, 2025

snyk-top-banner

Snyk has created this PR to upgrade commander from 13.1.0 to 14.0.0.

ℹ️ Keep your dependencies up-to-date. This makes it easier to fix existing vulnerabilities and to more quickly identify and fix newly disclosed vulnerabilities when they affect your project.


⚠️ Warning: This PR contains major version upgrade(s), and may be a breaking change.

  • The recommended version is 1 version ahead of your current version.

  • The recommended version was released 23 days ago.

Release notes
Package name: commander
  • 14.0.0 - 2025-05-18

    Added

    • support for groups of options and commands in the help using low-level .helpGroup() on Option and Command, and higher
      -level .optionsGroup() and .commandsGroup() which can be used in chaining way to specify group title for following option
      s/commands (#2328)
    • support for unescaped negative numbers as option-arguments and command-arguments (#2339)
    • TypeScript: add parseArg property to Argument class (#2359)

    Fixed

    • remove bogus leading space in help when option has default value but not a description (#2348)
    • .configureOutput() now makes copy of settings instead of modifying in-place, fixing side-effects (#2350)

    Changed

    • Breaking: Commander 14 requires Node.js v20 or higher
    • internal refactor of Help class adding .formatItemList() and .groupItems() methods (#2328)
  • 13.1.0 - 2025-01-20

    Added

    • support a pair of long option flags to allow a memorable shortened flag, like .option('--ws, --workspace') (#2312)
from commander GitHub release notes

Important

  • Warning: This PR contains a major version upgrade, and may be a breaking change.
  • Check the changes in this PR to ensure they won't cause issues with your project.
  • This PR was automatically created by Snyk using the credentials of a real user.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open upgrade PRs.

For more information:

Summary by CodeRabbit

  • Chores
    • Updated the "commander" dependency to version 14.0.0.

Snyk has created this PR to upgrade commander from 13.1.0 to 14.0.0.

See this package in npm:
commander

See this project in Snyk:
https://app.snyk.io/org/acinader/project/21343059-02d9-4182-87d7-718a44b181ef?utm_source=github&utm_medium=referral&page=upgrade-pr
Copy link

I will reformat the title to use the proper commit message syntax.

@parse-github-assistant parse-github-assistant bot changed the title [Snyk] Upgrade commander from 13.1.0 to 14.0.0 refactor: Upgrade commander from 13.1.0 to 14.0.0 Jun 10, 2025
Copy link

coderabbitai bot commented Jun 10, 2025

📝 Walkthrough

Walkthrough

The version of the "commander" dependency in the package.json file was updated from 13.1.0 to 14.0.0. No other files or dependencies were changed.

Changes

File Change Summary
package.json Updated "commander" dependency from 13.1.0 to 14.0.0

Sequence Diagram(s)


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

🚀 Thanks for opening this pull request!

@parseplatformorg
Copy link
Contributor Author

🎉 Snyk checks have passed. No issues have been found so far.

security/snyk check is complete. No issues have been found. (View Details)

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 1ae3176 and 254999e.

⛔ Files ignored due to path filters (1)
  • package-lock.json is excluded by !**/package-lock.json
📒 Files selected for processing (1)
  • package.json (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (4)
  • GitHub Check: Check Definitions
  • GitHub Check: Circular Dependencies
  • GitHub Check: Node Engine Check
  • GitHub Check: Code Analysis (javascript)

@@ -28,7 +28,7 @@
"@parse/fs-files-adapter": "3.0.0",
"@parse/push-adapter": "6.11.0",
"bcryptjs": "3.0.2",
"commander": "13.1.0",
"commander": "14.0.0",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Verification agent

🧩 Analysis chain

Commander 14.0.0 requires Node.js ≥20, update engines & lockfile

Commander v14 drops support for Node <20, but your "engines.node" still allows Node 18. This mismatch can cause install/runtime failures on unsupported Node versions. Please:

  1. Update the "engines" field to require Node ≥20.
  2. Regenerate your lock files (package-lock.json/yarn.lock) to pick up the new version.
  3. Smoke-test the CLI (e.g. node bin/parse-server --help) to catch any breaking changes in command definitions.

Apply this diff:

--- a/package.json
+++ b/package.json
@@ -148,7 +148,7 @@
   },
-  "engines": {
-    "node": ">=18.20.4 <19.0.0 || >=20.18.0 <21.0.0 || >=22.12.0 <23.0.0"
-  },
+  "engines": {
+    "node": ">=20.0.0 <21.0.0 || >=22.12.0 <23.0.0"
+  },

🏁 Script executed:

#!/bin/bash
# Fetch the engines requirement for commander v14.0.0 from npm
npm view commander@14.0.0 engines --json

# Show the current "engines" field in our package.json
rg '"engines"' -n -A2 package.json

Length of output: 206


Commander v14 requires Node ≥20 – update engines & lockfile

Your current package.json still allows Node 18 even though Commander v14 only supports Node ≥20:

• package.json (lines 149–150)

"engines": {
  "node": ">=18.20.4 <19.0.0 || >=20.18.0 <21.0.0 || >=22.12.0 <23.0.0"
},

Please:

  1. Drop the Node 18 range and require Node ≥20.
  2. Regenerate your lockfile (package-lock.json/yarn.lock).
  3. Smoke-test the CLI (e.g. node bin/parse-server --help).

Suggested diff:

--- a/package.json
+++ b/package.json
@@ -148,7 +148,7 @@
   },
-  "engines": {
-    "node": ">=18.20.4 <19.0.0 || >=20.18.0 <21.0.0 || >=22.12.0 <23.0.0"
-  },
+  "engines": {
+    "node": ">=20.0.0 <21.0.0 || >=22.12.0 <23.0.0"
+  },
🤖 Prompt for AI Agents
In package.json at line 31 and around lines 149-150, the "engines.node" field
still allows Node 18, but commander v14.0.0 requires Node.js version 20 or
higher. Update the "engines.node" field to drop the Node 18 range and require
Node >=20. After updating, regenerate your lockfile (package-lock.json or
yarn.lock) to reflect this change. Finally, run a smoke test on the CLI (e.g.,
node bin/parse-server --help) to ensure compatibility with the new Node version.

Copy link

codecov bot commented Jun 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.00%. Comparing base (1ae3176) to head (254999e).

Additional details and impacted files
@@            Coverage Diff             @@
##            alpha    #9792      +/-   ##
==========================================
+ Coverage   92.99%   93.00%   +0.01%     
==========================================
  Files         187      187              
  Lines       15082    15082              
  Branches      174      174              
==========================================
+ Hits        14025    14027       +2     
+ Misses       1045     1043       -2     
  Partials       12       12              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants