Skip to content

refactor: Upgrade commander from 13.1.0 to 14.0.0 #9792

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: alpha
Choose a base branch
from
Open

refactor: Upgrade commander from 13.1.0 to 14.0.0 #9792

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 8 additions & 24 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@
"@parse/fs-files-adapter": "3.0.0",
"@parse/push-adapter": "6.11.0",
"bcryptjs": "3.0.2",
"commander": "13.1.0",
"commander": "14.0.0",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Verification agent

🧩 Analysis chain

Commander 14.0.0 requires Node.js ≥20, update engines & lockfile

Commander v14 drops support for Node <20, but your "engines.node" still allows Node 18. This mismatch can cause install/runtime failures on unsupported Node versions. Please:

  1. Update the "engines" field to require Node ≥20.
  2. Regenerate your lock files (package-lock.json/yarn.lock) to pick up the new version.
  3. Smoke-test the CLI (e.g. node bin/parse-server --help) to catch any breaking changes in command definitions.

Apply this diff:

--- a/package.json
+++ b/package.json
@@ -148,7 +148,7 @@
   },
-  "engines": {
-    "node": ">=18.20.4 <19.0.0 || >=20.18.0 <21.0.0 || >=22.12.0 <23.0.0"
-  },
+  "engines": {
+    "node": ">=20.0.0 <21.0.0 || >=22.12.0 <23.0.0"
+  },

🏁 Script executed:

#!/bin/bash
# Fetch the engines requirement for commander v14.0.0 from npm
npm view commander@14.0.0 engines --json

# Show the current "engines" field in our package.json
rg '"engines"' -n -A2 package.json

Length of output: 206

Commander v14 requires Node ≥20 – update engines & lockfile

Your current package.json still allows Node 18 even though Commander v14 only supports Node ≥20:

• package.json (lines 149–150)

"engines": {
  "node": ">=18.20.4 <19.0.0 || >=20.18.0 <21.0.0 || >=22.12.0 <23.0.0"
},

Please:

  1. Drop the Node 18 range and require Node ≥20.
  2. Regenerate your lockfile (package-lock.json/yarn.lock).
  3. Smoke-test the CLI (e.g. node bin/parse-server --help).

Suggested diff:

--- a/package.json
+++ b/package.json
@@ -148,7 +148,7 @@
   },
-  "engines": {
-    "node": ">=18.20.4 <19.0.0 || >=20.18.0 <21.0.0 || >=22.12.0 <23.0.0"
-  },
+  "engines": {
+    "node": ">=20.0.0 <21.0.0 || >=22.12.0 <23.0.0"
+  },
🤖 Prompt for AI Agents 
In package.json at line 31 and around lines 149-150, the "engines.node" field
still allows Node 18, but commander v14.0.0 requires Node.js version 20 or
higher. Update the "engines.node" field to drop the Node 18 range and require
Node >=20. After updating, regenerate your lockfile (package-lock.json or
yarn.lock) to reflect this change. Finally, run a smoke test on the CLI (e.g.,
node bin/parse-server --help) to ensure compatibility with the new Node version.

"cors": "2.8.5",
"deepcopy": "2.1.0",
"express": "5.1.0",
Expand Down
Loading