-
-
Notifications
You must be signed in to change notification settings - Fork 4.8k
fix: Parse Server option rateLimit.zone does not use default value ip
#9941
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Parse Server option rateLimit.zone does not use default value ip
#9941
Conversation
|
🚀 Thanks for opening this pull request! |
📝 WalkthroughWalkthroughAdded an explicit default value Changes
Sequence Diagram(s)(omitted) — changes are documentation/default-value only; no control-flow modifications to illustrate. Estimated code review effort🎯 2 (Simple) | ⏱️ ~5–15 minutes
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (3)
🚧 Files skipped from review as they are similar to previous changes (1)
🧰 Additional context used🧠 Learnings (2)📓 Common learnings📚 Learning: 2025-11-08T13:46:04.940ZApplied to files:
🪛 Biome (2.1.2)src/Options/index.js[error] 373-373: Expected a statement but instead found '?'. Expected a statement here. (parse) ⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (6)
🔇 Additional comments (3)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
Codecov Report✅ All modified and coverable lines are covered by tests.
Additional details and impacted files@@ Coverage Diff @@
## alpha #9941 +/- ##
==========================================
- Coverage 93.08% 84.51% -8.57%
==========================================
Files 187 187
Lines 15275 15275
Branches 177 177
==========================================
- Hits 14219 12910 -1309
- Misses 1044 2353 +1309
Partials 12 12 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## alpha #9941 +/- ##
==========================================
- Coverage 93.09% 93.08% -0.01%
==========================================
Files 188 188
Lines 15298 15298
Branches 177 177
==========================================
- Hits 14241 14240 -1
- Misses 1045 1046 +1
Partials 12 12 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
# [8.5.0-alpha.14](8.5.0-alpha.13...8.5.0-alpha.14) (2025-11-23) ### Bug Fixes * Parse Server option `rateLimit.zone` does not use default value `ip` ([#9941](#9941)) ([12beb8f](12beb8f))
|
🎉 This change has been released in version 8.5.0-alpha.14 |
Pull Request
Issue
Parse Server option
rateLimit.zonedoes not use default valueip. Due to typos in the code comment the parser doesn't recognize the default value.Approach
Fix code comment.
Summary by CodeRabbit
New Features
Documentation
✏️ Tip: You can customize this high-level summary in your review settings.