fix : .env conflict message

Author: patternhelloworld

.docker/nginx/template/entrypoint.sh

@@ -17,7 +17,7 @@ echo "[INSIDE_NGINX_CONTAINER][NOTICE] Start Logrotate (every hour at minute 1)
 service cron restart || echo "[WARN] Restarting Cron failed."
 
 
-# From this point on, the configuration of the NGINX consul-template begins.
+# From this point on, the configuration of the NGINX template begins.
 if [[ ! -d /etc/templates ]]; then
     echo "[INSIDE_NGINX_CONTAINER][NOTICE] As the directory name '/etc/templates' does NOT exist, it has been created."
     mkdir /etc/templates

README.md

@@ -62,13 +62,12 @@
        - Step 2: Perform a health check with customized settings defined in your .env file
      - Nginx Router Test Container
      - External Integrity Check
-     - Nginx Prepared Plan
      - Rollback Procedures
      - Additional Know-hows on Docker: Tips and best practices for optimizing your Docker workflow and deployment processes
    - For example, Traefik offers powerful dynamic configuration and service discovery; however, certain errors, such as a failure to detect containers (due to issues like unrecognized certificates), can lead to frustrating 404 errors that are hard to trace through logs alone.
      - https://stackoverflow.com/questions/76660749/traefik-404-page-not-found-when-use-https
      - https://community.traefik.io/t/getting-bad-gateway-404-page-when-supposed-to-route-to-container-port-8443/20398
-   - Manipulates NGINX configuration files directly to ensure container accessibility. It also tests configuration files by launching a test NGINX Docker instance, and if an NGINX config update via Consul-Template fails, Prepared Plan provided is activated to ensure connectivity to your containers.
+   - Manipulates NGINX configuration files directly to ensure container accessibility.
 
 
 3. **Track Blue-Green status and the Git SHA of your running container for easy monitoring.**
@@ -159,7 +158,6 @@ graph TD;
 | docker                                | 24~27            | Manual            | I think too old versions could cause problems, and the lastest version v27.x causes only a warning message.                    |
 | docker-compose                        | 2                | Manual            | I think too old versions could cause problems, and the v2 is recommended.                                                      |
 
-- Although issues with wrong versions of these libraries can cause errors, there are several safety mechanisms in place to prevent the server from being interrupted. For example, when you run run.sh, early on it checks: 1) the existence of the required libraries, 2) the NGINX Prepared Function section below, and 3) in case of restarting Nginx (NGINX_RESTART=true in .env), a preliminary check for integrity (check_nginx_templates_integrity in use-nginx.sh).
 - For ``docker-compose``, if you use a version above v2.25.0, you will see a warning message: ``[WARN] The attribute 'version' is obsolete and will be ignored. Please remove it to avoid potential confusion``. You can ignore it at this point.
 - For MAC users, ``GNU-based bash, sed, grep`` should be installed.
 - For MAC users, ``SHARED_VOLUME_GROUP_*`` on .env are skipped.
@@ -389,7 +387,7 @@ For all echo messages or properties .env, the following terms indicate...
 ```shell
 bash check-current-states.sh
 # The output example
-[DEBUG] ! Checking which (Blue OR Green) is currently running... (Base Check) : consul_pointing(blue), nginx_pointing(blue}), blue_status(running), green_status(exited)
+[DEBUG] ! Checking which (Blue OR Green) is currently running... (Base Check) : nginx_pointing(blue}), blue_status(running), green_status(exited)
 [DEBUG] ! Checked which (Blue OR Green) is currently running... (Final Check) : blue_score : 130, green_score : 27, state : blue, new_state : green, state_for_emergency : blue, new_upstream : https://PROJECT_NAME:8300.
 ```
 - The higher the score a state receives, the more likely it is to be the currently running state. So the updated App should be deployed as the non-occupied state(new_state).

emergency-all-down-and-up.sh

@@ -38,6 +38,4 @@ for container_id in "${container_ids[@]}"; do
     docker container rm "$container_id"  || echo "[DEBUG] H"
 done
 
-sleep 5
-
-consul_down_and_up_with_network
+sleep 5

nginx-blue-green-activate.sh

@@ -15,7 +15,7 @@ new_upstream=$3
 echo "[NOTICE] new_state : ${new_state}, old_state : ${old_state}, new_upstream : ${new_upstream}"
 
 
-# The meaning of "${pid_was} != '-'" is that when Nginx has fully started, the BLUE-GREEN change operation is performed in CONSUL.
+# The meaning of "${pid_was} != '-'" is that when Nginx has fully started, the BLUE-GREEN change operation is performed.
 echo "[NOTICE] Check if Nginx is completely UP."
 for retry_count in {1..5}; do
   pid_was=$(docker exec ${project_name}-nginx pidof nginx 2>/dev/null || echo '-')

run.sh

@@ -269,10 +269,10 @@ _main() {
 
     if [[ ${orchestration_type} != 'stack' ]]; then
       docker-compose -f docker-${orchestration_type}-${project_name}.yml stop ${project_name}-${initially_cached_old_state}
-      echo "[NOTICE] The previous (${initially_cached_old_state}) container (initially_cached_old_state) has been stopped because the deployment was successful. (If NGINX_RESTART=true or CONSUL_RESTART=true, existing containers have already been terminated in the load_all_containers function.)"
+      echo "[NOTICE] The previous (${initially_cached_old_state}) container (initially_cached_old_state) has been stopped because the deployment was successful. (If NGINX_RESTART=true, existing containers have already been terminated in the load_all_containers function.)"
     else
        docker stack rm ${project_name}-${initially_cached_old_state}
-       echo "[NOTICE] The previous (${initially_cached_old_state}) service (initially_cached_old_state) has been stopped because the deployment was successful. (If NGINX_RESTART=true or CONSUL_RESTART=true, existing containers have already been terminated in the load_all_containers function.)"
+       echo "[NOTICE] The previous (${initially_cached_old_state}) service (initially_cached_old_state) has been stopped because the deployment was successful. (If NGINX_RESTART=true, existing containers have already been terminated in the load_all_containers function.)"
     fi
 
     display_checkpoint_message "CURRENT APP_URL: ${app_url}."

use-common.sh

@@ -220,7 +220,11 @@ cache_non_dependent_global_vars() {
   skip_building_app_image=$(get_value_from_env "SKIP_BUILDING_APP_IMAGE")
 
   if [[ ${docker_layer_corruption_recovery} == 'true' && ${skip_building_app_image} == 'true' ]]; then
-      echo "[ERROR] On .env, docker_layer_corruption_recovery=true and skip_building_app_image=true as well. That does NOT make sense, as 'docker_layer_corruption_recovery=true' removes all images first." && exit 1
+      echo "[ERROR] Configuration conflict in .env: 'docker_layer_corruption_recovery=true' and 'skip_building_app_image=true' cannot coexist. 'docker_layer_corruption_recovery=true' removes all images, so skipping the app image build is not logical." && exit 1
+  fi
+
+  if [[ ${docker_layer_corruption_recovery} == 'true' && ${nginx_restart} == 'false' ]]; then
+      echo "[ERROR] Configuration conflict in .env: 'docker_layer_corruption_recovery=true' and 'nginx_restart=false' cannot coexist. 'docker_layer_corruption_recovery=true' removes all images, which requires a restart of Nginx." && exit 1
   fi
 
   orchestration_type=$(get_value_from_env "ORCHESTRATION_TYPE")