Added support for the Replenishment API#103
Open
robertdbailey wants to merge 2 commits intomasterfrom
Open
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for Amazon's Replenishment API version 2022-11-07, which enables sellers to manage subscription offers and retrieve related business metrics.
- Implemented three main API operations: list_offers, list_offer_metrics, and get_selling_partner_metrics
- Added comprehensive test coverage with mock data for various scenarios including filters and forecast metrics
- Created supporting test fixtures with realistic JSON response data
Reviewed Changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| lib/muffin_man.rb | Added require statement for the new replenishment module |
| lib/muffin_man/replenishment/v20221107.rb | Main implementation of the Replenishment API client with three endpoint methods |
| spec/muffin_man/replenishment/v20221107_spec.rb | Test suite covering all three API operations with various parameter combinations |
| spec/support/sp_api_helpers.rb | Added stub methods for mocking replenishment API endpoints in tests |
| spec/support/replenishment/*.json | Test fixture files containing mock API responses for different scenarios |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| # @return [Hash] Request body | ||
| def build_search_request_body(marketplace_ids, params, allowed_params) | ||
| marketplace_ids = Array(marketplace_ids) | ||
|
|
There was a problem hiding this comment.
Remove the trailing whitespace after marketplace_ids = Array(marketplace_ids).
Suggested change
robertdbailey
requested review from
gavinritchie,
natesalisbury and
sanjjaymahalingam
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.