fix: allow custom admin user collection in query presets constraints

[sam-gab]

Query preset "Specific User" constraints is currently fixed to users collection.
However, this will fail if one has a custom admin user collection.

[sam-gab]

@jacobsfletch I added the fallback as it seems relatedTo can't be undefined in a relationship field type - hence the lint errors.

Could you please help me check why the workflow is stuck? Thank you... 😃

[jacobsfletch]

@sam-gab the fallback should not be added just to satisfy lint. In this case we need to either update the types to reflect the sanitized fallback or assert the type directly.

[sam-gab]

@jacobsfletch Apologies mate, maybe I'm just blur - don't quite understand what you mean. Do you mean I need to:

1. Update the relationTo param for a relationship field type to be an optional field? Or
2. Update the admin param in the payload configs to be a required field? Or
3. Assert that config.admin.user is always provided for the Query Preset constraint feature to work?

[jacobsfletch]

@sam-gab the args passed into the getConstraints function does in fact have a resolved admin.user, but the types are incorrectly defining it as optional. This means we can safely assert the type on that property in order to satisfy lint.

For example:

{
  // ...
  relationTo: config.admin.user as string
}

This works because the config arg is typed as Config, but in reality is Partial<SanitizedConfig>. See this line.

For now, we can keep the fallback as you have it, although it would technically never be used.

The more permanent fix here, on the other hand, would be to properly type the args passed into this function so that neither a type assertion or a fallback is necessary. I think for now, we can merge your change as is, and just mark it with a todo.

[github-actions]

🚀 This is included in version v3.37.0