Remove Access Token from MXO Migration guide & Demo (#165)

Author: scannillo

Demo/Demo.xcodeproj/project.pbxproj

@@ -13,8 +13,6 @@
 		536A5CA62898A730005C053D /* NativeCheckoutDemoViewController.swift in Sources */ = {isa = PBXBuildFile; fileRef = 536A5CA52898A730005C053D /* NativeCheckoutDemoViewController.swift */; };
 		536A5CA82898AA2A005C053D /* SwiftUINativeCheckoutDemo.swift in Sources */ = {isa = PBXBuildFile; fileRef = 536A5CA72898AA2A005C053D /* SwiftUINativeCheckoutDemo.swift */; };
 		53B9E8EA28C93B4400719239 /* OrderRequestHelpers.swift in Sources */ = {isa = PBXBuildFile; fileRef = 53B9E8E928C93B4400719239 /* OrderRequestHelpers.swift */; };
-		53DBDAA52885D83100E0ABA1 /* AccessTokenResponse.swift in Sources */ = {isa = PBXBuildFile; fileRef = 53DBDAA42885D83100E0ABA1 /* AccessTokenResponse.swift */; };
-		53DBDAA72885D86F00E0ABA1 /* AccessTokenRequest.swift in Sources */ = {isa = PBXBuildFile; fileRef = 53DBDAA62885D86F00E0ABA1 /* AccessTokenRequest.swift */; };
 		8052E2A529B684BA00B33FBC /* PPRiskMagnes.xcframework in Frameworks */ = {isa = PBXBuildFile; fileRef = 8052E2A229B684A600B33FBC /* PPRiskMagnes.xcframework */; };
 		8052E2A629B684BA00B33FBC /* PPRiskMagnes.xcframework in Embed Frameworks */ = {isa = PBXBuildFile; fileRef = 8052E2A229B684A600B33FBC /* PPRiskMagnes.xcframework */; settings = {ATTRIBUTES = (CodeSignOnCopy, RemoveHeadersOnCopy, ); }; };
 		80561B3826FB5F0F0023138C /* CardDemoViewController.swift in Sources */ = {isa = PBXBuildFile; fileRef = 80561B3726FB5F0F0023138C /* CardDemoViewController.swift */; };
@@ -110,8 +108,6 @@
 		536A5CA52898A730005C053D /* NativeCheckoutDemoViewController.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = NativeCheckoutDemoViewController.swift; sourceTree = "<group>"; };
 		536A5CA72898AA2A005C053D /* SwiftUINativeCheckoutDemo.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = SwiftUINativeCheckoutDemo.swift; sourceTree = "<group>"; };
 		53B9E8E928C93B4400719239 /* OrderRequestHelpers.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = OrderRequestHelpers.swift; sourceTree = "<group>"; };
-		53DBDAA42885D83100E0ABA1 /* AccessTokenResponse.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = AccessTokenResponse.swift; sourceTree = "<group>"; };
-		53DBDAA62885D86F00E0ABA1 /* AccessTokenRequest.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = AccessTokenRequest.swift; sourceTree = "<group>"; };
 		8052E2A229B684A600B33FBC /* PPRiskMagnes.xcframework */ = {isa = PBXFileReference; lastKnownFileType = wrapper.xcframework; name = PPRiskMagnes.xcframework; path = ../Frameworks/XCFrameworks/PPRiskMagnes.xcframework; sourceTree = "<group>"; };
 		80561B3726FB5F0F0023138C /* CardDemoViewController.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = CardDemoViewController.swift; sourceTree = "<group>"; };
 		80561B3926FB5F1C0023138C /* PayPalWebCheckoutViewController.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = PayPalWebCheckoutViewController.swift; sourceTree = "<group>"; };
@@ -279,8 +275,6 @@
 		80F33CEB26F8E799006811B1 /* Models */ = {
 			isa = PBXGroup;
 			children = (
-				53DBDAA62885D86F00E0ABA1 /* AccessTokenRequest.swift */,
-				53DBDAA42885D83100E0ABA1 /* AccessTokenResponse.swift */,
 				5301468B28918B4D00184F22 /* ApprovalResult.swift */,
 				3B80D50D2A291C0800D2EAC4 /* ClientIDRequest.swift */,
 				3B80D50F2A291CB100D2EAC4 /* ClientIDResponse.swift */,
@@ -501,13 +495,11 @@
 				BED04233271084DF00C80954 /* CardFormatter.swift in Sources */,
 				CB9ED44E28411B120081F4DE /* SwiftUIPaymentButtonDemo.swift in Sources */,
 				80561B3E26FB72D80023138C /* FeatureBaseViewController.swift in Sources */,
-				53DBDAA72885D86F00E0ABA1 /* AccessTokenRequest.swift in Sources */,
 				BE31187C273F00B60021C5A2 /* DemoUIFramework.swift in Sources */,
 				BE9F36DC274578D100AFC7DA /* FeatureBaseViewControllerRepresentable.swift in Sources */,
 				BECD84A027036DC2007CCAE4 /* Environment.swift in Sources */,
 				806F1E3D26B85367007A60E6 /* ViewController.swift in Sources */,
 				80F33CF126F8E7D9006811B1 /* ProcessOrderParams.swift in Sources */,
-				53DBDAA52885D83100E0ABA1 /* AccessTokenResponse.swift in Sources */,
 				53B9E8EA28C93B4400719239 /* OrderRequestHelpers.swift in Sources */,
 				CB9ED44C283FDA900081F4DE /* PaymentButtonEnums+Extension.swift in Sources */,
 				BED041B1270CB33900C80954 /* CustomTextField.swift in Sources */,

Demo/Demo/Models/AccessTokenRequest.swift

@@ -10,7 +10,7 @@ final class DemoMerchantAPI {
     static let sharedService = DemoMerchantAPI()
     var clientID: String?
 
-    // To hardcode an access token and order ID for this demo app, set the below values
+    // To hardcode an order ID and client ID for this demo app, set the below values
     enum InjectedValues {
         static let orderID: String? = nil
         static let clientID: String? = nil

Demo/Demo/Models/AccessTokenResponse.swift

@@ -6,7 +6,7 @@ This guide outlines how to update your integration from using the soon-to-be-dep
 In order to use this migration guide, you must:
 
 1. Have a server-side integration with the [PayPal Orders v2 API](https://developer.paypal.com/docs/api/orders/v2/). Please update to Orders v2 if you're on [Payments V1](https://developer.paypal.com/docs/api/payments/v1/) or [NVP/SOAP](https://developer.paypal.com/api/nvp-soap/).
-1. Enable your server to [fetch an Access Token](https://developer.paypal.com/reference/get-an-access-token/).
+1. Obtain your client ID. Follow the steps in [Get Started](https://developer.paypal.com/api/rest/#link-getstarted) to create a client ID in your PayPal Developer Dashboard.
 1. Enable your server to create an [Order ID](https://developer.paypal.com/docs/api/orders/v2/).
 1. Enable your server to [PATCH](https://developer.paypal.com/docs/api/orders/v2/#orders_patch) an order.
     * _Note:_ This is **only required** if you create your order ID with [`shipping_preference`](https://developer.paypal.com/docs/api/orders/v2/#definition-order_application_context) = `GET_FROM_FILE`. See step 6 in the guides below.
@@ -32,22 +32,22 @@ In order to use this migration guide, you must:
 2. Update Configuration
 
     * Remove `CheckoutConfig` and related `set()` methods.
-    * Instantiate a `CoreConfig` with your Access Token from the [pre-requisite](#pre-requisites) steps.
+    * Instantiate a `CoreConfig` with your client ID from the [pre-requisite](#pre-requisites) steps.
     * Construct a `PayPalNativeCheckoutClient`.
     * Set delegates (more details to follow).
 
     ```diff
     private func configurePayPalCheckout() {
     -     let config = CheckoutConfig(
-    -         clientID: "<ACCESS_TOKEN>",
+    -         clientID: "<CLIENT_ID>",
     -         environment: .sandbox
     -     )
     -     Checkout.set(config: config)     
     -     Checkout.setCreateOrderCallback { createOrderAction in
     -         createOrderAction.set(orderId: "<ORDER_ID>")
     -     }
 
-    +     let coreConfig = CoreConfig(accessToken: "<ACCESS_TOKEN>"", environment: CorePayments.Environment.sandbox)
+    +     let coreConfig = CoreConfig(clientID: "<CLIENT_ID>"", environment: CorePayments.Environment.sandbox)
     +     paypalClient = PayPalNativeCheckoutClient(config: coreConfig)
     
     +     paypalClient?.delegate = self          // always required
@@ -180,9 +180,3 @@ In order to use this migration guide, you must:
 * CocoaPods
     * Remove `pod 'PayPalCheckout'` from your Podfile
     * Refresh your local `/Pods`
- 
-## Resources
-
-We migrated a sample app for you to reference:
-
-* [iOS PR](https://github.com/scannillo/paypal-xo-sample/pull/1): ➕101 lines ➖39 lines

Demo/Demo/Networking/DemoMerchantAPI.swift

@@ -31,7 +31,7 @@ This SDK supports:
 
 ## Client ID
 
-The PayPal SDK uses a client ID for authentication.
+The PayPal SDK uses a client ID for authentication. This can be found in your [PayPal Developer Dashboard](https://developer.paypal.com/api/rest/#link-getstarted).
 
 ## Modules
 

MOBILE_CHECKOUT_MIGRATION_GUIDE.md

@@ -8,7 +8,6 @@ import AuthenticationServices
 class CardClient_Tests: XCTestCase {
 
     let mockClientID = "mockClientId"
-    let mockAccessToken = "mockAccessToken"
 
     // MARK: - Helper Properties
 

README.md

@@ -5,7 +5,6 @@ import XCTest
 class EligibilityAPI_Tests: XCTestCase {
 
     let mockClientID = "mockClientId"
-    let mockAccessToken = "mockAccessToken"
     let mockURLSession = MockURLSession()
     var coreConfig: CoreConfig!
     var graphQLClient: GraphQLClient!