demo app changes for checkout app switch #351
Merged
+80
−72
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sshropshire
reviewed
Sep 10, 2025
Comment on lines
+16
to
+17
| /// - S1: no vault (paymentSource = nil) | ||
| /// - S5: vault (paymentSource.card.attributes.vault) |
Collaborator
There was a problem hiding this comment.
Hey what do S1 and S5 mean?
Collaborator
Author
There was a problem hiding this comment.
Oh I just listed cases for order creation.
Scenario 1, 2, 3, 4, 5
- standard, no payment source
- standard with app switch
- checkout with PayPal vault (no app-switch)
- checkout with PayPal vault + app-switch
- checkout with card vault
1-4 I listed on PayPalWebViewModel, 1 and 5 in CardPaymentVM
Collaborator
There was a problem hiding this comment.
Oh nice we could define these scenarios in the README to make it more accessible. At first glance I honestly wasn't sure what S1, etc. was referring to.
Collaborator
Author
There was a problem hiding this comment.
Ah but this is on the demo app. We should have good documentations of this in our official docs for merchant server side calls.
sshropshire
approved these changes
Sep 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for changes
Summary of changes
Checklist
Authors