-
Notifications
You must be signed in to change notification settings - Fork 47
Demo App changes for Vault App Switch #354
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
init(appSwitchContext: AppSwitchContext? = nil) { | ||
self.appSwitchContext = appSwitchContext | ||
if appSwitchContext != nil { | ||
self.returnUrl = baseReturnHost + "/success" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am checking with checkout team on this, whether this can remain custom url scheme.
Ideally, we have ability to have happy path return_url back from PayPal app from the app switch context app_url.
I will make changes on it on subsequent PRs depending on answer we get.
For web checkout, iOS SDK constructs the ASWebAuthentication launch url with return_uri param that contains SDK specific custom url scheme, "sdk.ios.paypal"
So we can default to this in case of ineligibility or app not installed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🌊
Reason for changes
Summary of changes
Checklist
Authors