fine tuning

Author: Alexey Babak

src/Payment.php

@@ -124,8 +124,23 @@ public function getProductsArray(): array
         return $productsArray;
     }
 
-    /** @inheritDoc */
-    public function jsonSerialize()
+    /** @inheritdoc */
+    public function sumProductsAmount() : int
+    {
+        $sum = 0;
+        foreach ($this->getProducts() as $product) {
+            if (null === $product->getAmount() && (null === $product->getUnitPrice())) {
+                throw new PaymentException('Опишите цены позиций к оплате');
+            }
+
+            $sum += $product->getAmount() ?? ($product->getUnitPrice() * $product->getQuantity());
+        }
+
+        return $sum;
+    }
+
+    #[\ReturnTypeWillChange]
+    public function jsonSerialize(): string|bool
     {
         //TODO: проверка необходимых параметров
         $requestData = [
@@ -141,19 +156,4 @@ public function jsonSerialize()
 
         return json_encode($requestData, JSON_UNESCAPED_SLASHES|JSON_PRETTY_PRINT|JSON_UNESCAPED_UNICODE|JSON_UNESCAPED_LINE_TERMINATORS);
     }
-
-    /** @inheritdoc */
-    public function sumProductsAmount() : int
-    {
-        $sum = 0;
-        foreach ($this->getProducts() as $product) {
-            if (null === $product->getAmount() && (null === $product->getUnitPrice())) {
-                throw new PaymentException('Опишите цены позиций к оплате');
-            }
-
-            $sum += $product->getAmount() ?? ($product->getUnitPrice() * $product->getQuantity());
-        }
-
-        return $sum;
-    }
 }

src/PaymentInterface.php

@@ -106,4 +106,9 @@ public function getProductsArray() : array;
      * @throws PaymentException Ошибка оплаты
      */
     public function sumProductsAmount() : int;
+
+    /**
+     * @return string|bool
+     */
+    public function jsonSerialize() : string|bool;
 }