Skip to content

Commit df5eb3c

Browse files
committed
Bump Kafka versions
1 parent caa5de5 commit df5eb3c

File tree

4 files changed

+6
-6
lines changed

4 files changed

+6
-6
lines changed

build.sbt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,9 +9,9 @@ scalaVersion := "2.13.15"
99
val pekkoVersion = "1.1.2"
1010
val pekkoHTTPVersion = "1.1.0"
1111
val pekkoConnectorVersion = "1.0.2"
12-
val pekkoConnectorKafkaVersion = "1.0.0"
12+
val pekkoConnectorKafkaVersion = "1.1.0"
1313

14-
val kafkaVersion = "3.7.0"
14+
val kafkaVersion = "3.8.0"
1515
val activemqVersion = "5.18.5" // We are stuck with 5.x
1616
val artemisVersion = "2.37.0"
1717
val testContainersVersion = "1.20.1"

project/build.properties

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
sbt.version=1.10.2
1+
sbt.version=1.10.3

src/test/scala/alpakka/tcp_to_websockets/AlpakkaTrophySpec.scala

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ final class AlpakkaTrophySpec extends AsyncWordSpec with Matchers with BeforeAnd
3737
val numberOfMessages = 10
3838
Hl7TcpClient(numberOfMessages)
3939

40-
// With EmbeddedKafka there is one ERROR due to port binding at the start
40+
// With EmbeddedKafka there is one ERROR due to flaky port binding at the start
4141
new LogFileScanner().run(10, 10, "Starting test: Happy path should find all processed messages in WebsocketServer log", "ERROR").length should equal(1)
4242
// 10 + 1 Initial message
4343
new LogFileScanner().run(10, 10, "Starting test: Happy path should find all processed messages in WebsocketServer log", "WebsocketServer received:").length should equal(numberOfMessages + 1)

src/test/scala/util/LogFileScanner.scala

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ class LogFileScanner(localLogFilePath: String = "logs/application.log") {
1717

1818
private val fs: FileSystem = FileSystems.getDefault
1919

20-
// The patterns are case sensitive
20+
// The patterns are case-sensitive
2121
def run(scanDelaySeconds: Int = 0, scanForSeconds: Int = 5, searchAfterPattern: String, pattern: String): List[String] = {
2222
val path: Path = fs.getPath(localLogFilePath)
2323
val pollingInterval = 250.millis
@@ -52,7 +52,7 @@ class LogFileScanner(localLogFilePath: String = "logs/application.log") {
5252
/**
5353
* To process files that were created on different operating systems.
5454
*
55-
* @param path
55+
* @param path to log file
5656
* @return the line separator for the file
5757
*/
5858
def detectLineSeparator(path: Path): String = {

0 commit comments

Comments
 (0)